Are color random and scale module doing what is expected? about d3po HOT 6 CLOSED

On Tue, Aug 13, 2019, 4:45 AM Sylvain Lesage ***@***.***> wrote: See https://github.com/pachamaltese/d3po/blob/master/javascript/src/color/random.js and https://github.com/pachamaltese/d3po/blob/master/javascript/src/color/scale.js Reading the code, the expected behavior seems to be: // defined as: d3.scale.ordinal().range(["#bf3251", "#5c57d9", "#d6c650", "#406662", "#872a41", "#1c26b3", "#d05555", "#549e95", "#993f7b", "#dc8e7a", "#ede788", "#7485aa", "#4d6fd0", "#635b56", "#7454a6", "#a8c380", "#8abdb6", "#74c0e2", "#bcd8af", "#a1aafb", "#a17cb0", "#d1a1bc"]); var defaultScale = require("./scale.js"); console.assert(defaultScale(1) === "#5c57d9", "2nd color (idx=1) should be the second color in the defaultScale array") But it's not, because no domain is defined for the ordinal scale. The actual behavior is that every call to the defaultScale function will return the following value in the range. Thus, the values returned by https://github.com/pachamaltese/d3po/blob/master/javascript/src/color/random.js are not random at all. — You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub <#7>, or mute the thread <https://github.com/notifications/unsubscribe-auth/ACM7UOKNJCSKFXYE67PGABLQEJYBDANCNFSM4ILIPHCA> .

On Tue, Aug 13, 2019, 8:54 AM Sylvain Lesage ***@***.***> wrote: Yes, I understand that the set of colors has been chosen carefully and is not random. I was referring to https://github.com/pachamaltese/d3po/blob/master/javascript/src/color/random.js -> it seems that the expected behavior of that function is to pick a color randomly from that set of colors you chose. But it doesn't (see the reason in the issue above). Or did I miss something? — You are receiving this because you commented. Reply to this email directly, view it on GitHub <#7>, or mute the thread <https://github.com/notifications/unsubscribe-auth/ACM7UOLKLLJXAX2MNZ2S65LQEKVJPANCNFSM4ILIPHCA> .

On Tue, Aug 13, 2019, 9:01 AM Sylvain Lesage ***@***.***> wrote: I think the problem could be fixed by replacing: module.exports = d3.scaleOrdinal().range(["#bf3251", "#5c57d9", ..., "#d1a1bc"]); by module.exports = d3.scaleOrdinal().range(["#bf3251", "#5c57d9", ..., "#d1a1bc"]) .domain(d3.range(0,22)) .unknown(undefined); And all would work as expected, random.js included. — You are receiving this because you commented. Reply to this email directly, view it on GitHub <#7>, or mute the thread <https://github.com/notifications/unsubscribe-auth/ACM7UOJ5XUWYY676YFCU3HLQEKWC7ANCNFSM4ILIPHCA> .