opral / inlang-fink Goto Github PK

Context

Users have trouble with pushing because Fink isn't aware of
Therefore the lix API was extend by:

• LIX-82
• opral/monorepo#2897

Proposal

by Jan opral/monorepo#2897 (comment):

• check if forking is allowed, if not hide the fork feature
• user has admin rights permissions.admin, if not and app not installed, disable push and tell user to have admin install app
• if pull permission is false and allow forking is true only show the forking workflow

---

• update "Cannot access the repository**"** card to include the installation of the inlang GitHub app by the repository owner

Context

It's hard to find the project "website" without a searchbox.

Proposal

Have a searchbar for the projects

When we use paraglide-init for a list of languages to support, it will automatically regularize the string so that all letter are in lower case, for example ko-Kore becomes ko-kore and zh-HanT becomes zh-hant. However, when you add a new language from Fink settings, the regularization is not triggered (implemented), so if you input ko-Kore it will be kept as ko-Kore which makes inconsistency across inlang infrastructure.

BCP 47 and RFCs specified that letter casing of language tag must never be differentiated, albeit conventions similar to zh-Hant-TW are recommended for readability. However, for paraglide, usually the language tag will be involved as a part of a url, which are usually lower cased, so it is also understandable to normalize to lowercase.

I think we should either enforce lowercasing in Fink, or disable the enforcement in paraglide-init

Description

Hi !
I'm currently having an issue with Fink that I've never seen before. When I go on the online editor, it detects correctly my messages files and my translations. However, when I have edited them and I push on my branch, it creates a /messages folder, with all translations, in the root of my repository instead of modifying the current translations I already have in /frontend/messages

Configuration

Here is my project structure:

|--backend
|--frontend
   |--project.inlang
      |--project_id
      |--settings.json
   |--messages
      |--en.json
      |--fr.json

And here is the settings.json:

{
	"$schema": "https://inlang.com/schema/project-settings",
	"sourceLanguageTag": "en",
	"languageTags": ["en", "fr"],
	"modules": [
		"https://cdn.jsdelivr.net/npm/@inlang/message-lint-rule-empty-pattern@latest/dist/index.js",
		"https://cdn.jsdelivr.net/npm/@inlang/message-lint-rule-identical-pattern@latest/dist/index.js",
		"https://cdn.jsdelivr.net/npm/@inlang/message-lint-rule-missing-translation@latest/dist/index.js",
		"https://cdn.jsdelivr.net/npm/@inlang/message-lint-rule-without-source@latest/dist/index.js",
		"https://cdn.jsdelivr.net/npm/@inlang/message-lint-rule-valid-js-identifier@latest/dist/index.js",
		"https://cdn.jsdelivr.net/npm/@inlang/plugin-message-format@latest/dist/index.js",
		"https://cdn.jsdelivr.net/npm/@inlang/plugin-m-function-matcher@latest/dist/index.js"
	],
	"plugin.inlang.messageFormat": {
		"pathPattern": "./messages/{languageTag}.json"
	}
}

Question

It never did that before and I didn't change anything in my configuration since I use Inlang and Fink editor. I don't understand if it's coming from a regression or maybe a release which changes the base structure of an inlang project ?

I have completed my project and I am not able to push translations

Have a nice prompt during or after push that makes you think better collab with devs and asks: do you want to recommend Ninja + Sherlock to your devs.

Context

We need to re-open the tech stack decision. Lit for SPAs is not a good match.

• Shadow DOM style encapsulation collides with how SPAs are developed, especially with Tailwind CSS. The result is a constant flash of styles when navigating pages.
• Lit has no state management solution suited for SPAs. Using [context])https://www.npmjs.com/package/@lit/context) has no ergonomic way of setting state from childs. Every state change must come from the parent.
• Vike had client side routing hickups where a fresh request to the server was executed. Don't know why. Not worth investigating further.

Options

Framework

1. Stick with lit for fink and continue trying to make it work.
2. Use SolidJS as we did for fink v1
3. Use React.

Routing

1. Vike even though we don't need SSR stuff. Just routing.
2. If React is chosen, we can use production proven react router.

As Sherlock we want to rollout the settings component in Fink as well.

@samuel.stroschein said in SHERL-47:

this will be helpful for fink too, see https://discord.com/channels/897438559458430986/1084866774874468433/1242165023779061881

Context

• A repo with a fork parent is trying to run forkStatus
• The branch is switched
• Error is thrown

Proposal

This seems to occur in State.tsx in the forkStatus resource and its initialValue.

cc @jan.johannes

Problem

We do not appear to have tests to validate that inlang project errors are actually visible to users in Fink.
e.g message load errors on initial project open, or file save errors while editing messages.

Proposal

Add validation to ensure that project errors are visible to users in Fink.

Context

Since the new inlang-settings component is done, every app should use this instead of manage.inlang.com

Proposal

Replace link to manage with settings component

This issue origined from INECO-1

Context/Problem

For now, Fink relies on the growth of the ecosystem. Can we find other growth channels for now?
Ninja is one of these strategies. How are we gonna proceed with that?

Proposal: Let's start experimenting with ninja.

I would start doing the first experiments with PRs, to see if we can potentially automate stuff.

Context

It's overwhelming to look at the project selection.

• long paths that are hard to read
• paths have duplicate information to project name e.g. website/website.inlang is twice "ah this is the website project"

Proposal

Focus the project selection around project names by giving the path less importance by:

1. Only display the project name in the dropdown selector
2. Put the main focus in the dropdown selector on the project names, not paths
3. Remove {name}.inlang files from the path because every path ends with .inlang and {name} is shown at the beginning. There is no additional value in showing it.

Additional information

• this nudges users to name their projects [to avoid a project, project, project list]. imo this is good
• the proposal aligns with how we use web apps, see the figma screenshot

Tasks

• (1) only show project name in dropdown selector
• (2) main focus on project name instead of path in dropdown menu
• (3) directory path doesn't show {name}.inlang
• directory path shows dots (../*) to indicate that the path is shortened (see FINK-44)

@niklas.buchfink said in FINK-12:

Updating this, as Ninja should get cross-selled by Fink, but not Sherlock
(see FINK-8)

Any idea why this happens?
When I click on main then on the next load I get them.

@samuel.stroschein said in FINK-15:

also not on https://fink.inlang.com/github.com/StanGirard/quivr. forking also failed

Context

The plus button for adding a language is confusing because it's not a filter like "all" and "none is"

Proposal

Move plus button to a menu item "add a new language" which opens the FINK-21.

Context

@niklas.buchfink said in FINK-11:

After a few more thoughts.

Ideal UX

If I'm part of the team, I open the project, make my changes and it should be commited, when I'm done. (To support autosaving, these changes are collected and commited, when the user is done. The lix server might help with that in the future. Also for live collaboration)

I just open the file, make my changes and automatically open changes request, if I'm not part of the team. The team is notified and can decide to add this changes. (fork + pr workflow in the background)

If I want this file to diverge, I want to click copy. Maybe I we can offer features like, "get updates from the original" or "merge documents", but since the copy action was done, we don't assume PRs anymore and users explicitly state that the copy should be updated or merged with main. (same forking + pr workflow as well, but with explicit user actions)

Proposal

• sketch non-dev workflow in excalidraw
• streamline Lix workflow in the background
• take different use cases into account (external -> PR via fork, internal -> PR via branch)

Context

The public repo https://fink.inlang.com/github.com/spuithori/tokimekibluesky can't be opened without being signed in

https://www.loom.com/share/97f1aad71f6e407da95d98f9585a3b01?sid=85bebf68-7b8d-4b7d-9f3c-d98226697d7c

reproduction

open https://fink.inlang.com/github.com/spuithori/tokimekibluesky

I'm just curious. Niklas send me that video:

https://www.youtube.com/watch?v=ZxhXvnkcLQ4

Would it be helpful to have a list of features of what they offer?

Context

We should show the normal human-readable language names in the Fink language dropdown

Proposal

Use the [Intl.DisplayNames](https://developer.mozilla.org/en-US/docs/Web/JavaScript/Reference/Global_Objects/Intl/DisplayNames#language_display_names) to show the English DisplayName with the BCP-47 tag behind. e.g.

• German de
• American English en-US
• Traditional Chinese zh-Hant

Open question: Should we keep the sorting

1. based on languageTags and maybe have the displayName in brackets or
2. based on the displayNames

Context

If a user adds a language and data already exists, the message is not shown as the project data is not re-fetched with the latest settings.

Proposal

Refetch the project after a new language was added.

Context

https://discord.com/channels/897438559458430986/1130765707639001088/1227197368013684736

• Paraglide JS leads to errors in the test during the build of the @inlang/editor package

Proposal

Add vite-adapter to fix editor build on windows

All others are also in source-code but it is not added here. I would expect /website/webiste.inlang

this is the errror code i get when i try to save the changes in the document.

this is the line

and this is the change i am trying to save

Context

Some companies have forks disabled at the company level.

Proposal

• Detect disabled forks on company level (LIX-57)
• Don't show the fork button in LixFloat
• Branch workflow: Create translation branch -> add changes -> create PR

Context

https://discord.com/channels/@me/1087285008122781715/1225734725877108747

Proposal

Add exception if ninja is in the ref link

Context

When issues come up for Fink:

1. We can't roll back to an older version
2. It is difficult for us to understand since which version this problem exists
3. Fink always uses the newest version of lix and the inlang-message-sdk after updates are merged

Proposal

• Version Fink FINK-5
• Display the current version in the UI

Context

There are three different types of error that are difficult to handle.

Proposal

They should be typed and have the same format to reliably trigger the PushPermissionsDialog

Context

Currently, Fink fails if the branch doesnt exist when accessing it via the url param:

CProposal

Create a fallback to main / master to let for example sherlock provide a branch in the Open in Fink url which might not yet / anymore exist.

Context

Watch the LOOM:
https://www.loom.com/share/2ae4d0d8d9f244618e948d620a38d542

Observations:

1. Repo can't be accessed
2. Repo state does not reload
3. Tour is getting displayed despite 0 messages
4. Overlays aren't working correctly. Dropdown needs higher index / Tour should be hidden.

Proposal

I don't know which one are bugs or intended, please create the issues yourself:)

Hi, when i enter a text in fink newlines get messed up on commit:

Entering

Message

Header
- Point 1
- Point 2

will get committed as

Message
Header- Point 1-Point 2

This messes up a lot, I cannot use fink any more at the moment...

Also (may be related): When I copy the same text from fink to my local text editor the original message transforms to:

Message

Header

- Point 1

- Point 2

We should clean up the old changelog file.

Context

If you delete the lint filter via the cross in the end:

Lint is Missing Translation
-> Lint is not selected
-> Filter is removed

https://fink.inlang.com/github.com/opral/example?project=%2Fproject.inlang&lint=messageLintRule.inlang.missingTranslation&lang=en&lang=de

Proposal

The lint filter should be removed immediately:
Lint is Missing Translation
-> Filter is removed

Context

open any repo with fink. the console shows a 401 and fink shows "no access to repo"

Context

INWEB-96 leads to an unsatisfying open fink experience for https://fink.inlang.com/github.com/opral/monorepo:

The mock project inlang-nextjs/project.inlang is opened instead of the project i always want to edit website.inlang.

Proposal

Save the project selection of the user in localstorage to re-open the last opened project when opening a repository.

Maintainers can push directly, they don't need to open a PR

Context

Same as FINK-45 but for branches.

Proposal

Same as FINK-45 but for branches.

• Create project (dashboard > recent)

Failed to push changes
Please try again or file a bug. Failed to push

I have all my translation finished but this message keeps on appearing