Comments (4)
@jan.johannes I created some cases with a second test user:
- "hiding the fork feature if forking is not allowed" is not needed as this feature only exists on private repos in organizations:
a) User is not a collaborator and can't load the repo
b) User is a collaborator and collaborators are allowed to push directly (or create PRs via branches which is not implemented yet) - admins can't install apps. Even admins can only request an installation or update of the permissions from the owners of the repo/organization. To know if a user can update the app's permissions, we need to know the owner status instead.
- I don't know if "not having pull permissions" is a case because there is no role for that.
a) If a user has no permissions to the repo, he can't open it
b) With read-only access to a repo, he has rights to clone or pull and he is prompted to update the app permissions as the returning code is 403. We should distinguish this from the missing app permission and the user not having sufficient permissions from the organization.
In any case, the user can click on add permissions and select the organization to request permissions from the owner (if he is not the owner).
The important thing here is that we should detect, if the user and app have sufficient permissions to push or if user is able to update the permissions of the app in the organization. This way we can prompt the user before making changes that might be lost.
from inlang-fink.
Scenario: User (Collaborator with push permissions) wants to contribute to a public repo. Here I see two common issues:
- User installs the app not for the organization, but for the own account. It might be possible to skip the selection, by fetching the target-id of the GitHub repo and direct to
https://github.com/apps/inlang-dev2/installations/new/permissions?target_id={target_id}
instead of "https://github.com/apps/inlang-dev2/installations/select_target" - If the repo is public and the user is a collaborator, the user can make the changes and might be prompted to update the permissions. If the user is not a owner, an updated needs to be requested from the owner and the changes are lost.
from inlang-fink.
I am also struggling with this issue.
I am trying on a private repo inside an organization.
I am the owner of the organization. I have verified that inlang has access to the repo that I am trying to push to. I also tried to manually include myself on that specific repo.
There are no special rules on any branched preventing commits or PRs. (I've tried selecting a branch which is not main as well).
I can open the repo and edit just fine.
When I click push, I get the success toast on the bottom of the screen.
But there aren't any new PRs on the repo
![image](https://private-user-images.githubusercontent.com/5804417/352673698-852d7175-80e3-4929-aedd-3c804107bd25.png?jwt=eyJhbGciOiJIUzI1NiIsInR5cCI6IkpXVCJ9.eyJpc3MiOiJnaXRodWIuY29tIiwiYXVkIjoicmF3LmdpdGh1YnVzZXJjb250ZW50LmNvbSIsImtleSI6ImtleTUiLCJleHAiOjE3MjM0NDc3NDUsIm5iZiI6MTcyMzQ0NzQ0NSwicGF0aCI6Ii81ODA0NDE3LzM1MjY3MzY5OC04NTJkNzE3NS04MGUzLTQ5MjktYWVkZC0zYzgwNDEwN2JkMjUucG5nP1gtQW16LUFsZ29yaXRobT1BV1M0LUhNQUMtU0hBMjU2JlgtQW16LUNyZWRlbnRpYWw9QUtJQVZDT0RZTFNBNTNQUUs0WkElMkYyMDI0MDgxMiUyRnVzLWVhc3QtMSUyRnMzJTJGYXdzNF9yZXF1ZXN0JlgtQW16LURhdGU9MjAyNDA4MTJUMDcyNDA1WiZYLUFtei1FeHBpcmVzPTMwMCZYLUFtei1TaWduYXR1cmU9ZGFjNmMwNWE2NzE5YTBmZDVkZjEyYmZhYjM3NTJmMzIyYzQxNjIxYzQ1NWI3NjUyMGEzMGIzY2I1MTY1OTNjMiZYLUFtei1TaWduZWRIZWFkZXJzPWhvc3QmYWN0b3JfaWQ9MCZrZXlfaWQ9MCZyZXBvX2lkPTAifQ.xrfYEUHzdVQAped1U1GmbJRhLFl6jPkAjjdMZCAeghc)
from inlang-fink.
@fabiopk why do you expect to get a pr when you press "push"? this will directly push your changes to the branch.
from inlang-fink.
Related Issues (20)
- add supported i18n libraries to fink product page HOT 11
- public repo can't be opened HOT 3
- the doc won't let me push changes HOT 4
- Not able to push translations HOT 4
- Show displayNames of language in Fink HOT 1
- Fink doesn't show me the other branches HOT 6
- Why did it add source-code in project dropdown | Fink HOT 3
- searchable projects HOT 1
- search for branches HOT 1
- save last selected project HOT 1
- Make PushException in Fink consistent
- Test issue
- Failed to push changes HOT 2
- forking errors with 404 HOT 1
- focus project selection on project names instead of path/to/inlang.project to reduce cognitive load HOT 1
- Newlines not committed correctly in fink HOT 3
- fink can't open repos anymore HOT 4
- Inconsistent behavior for letter-casing in adding language in Fink and paraglide-init HOT 2
- decide on tech stack HOT 8
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from inlang-fink.