Comments (6)
I'm flexible...if we're migrating soon then just iohub
is fine.
from waveorder.
I think the MM metadata (IndexMap
) is used to get the correct ordering of the data axes.
AFAIK reader.files
is only used to extract metadata that is shared across the dataset (from reader.files[0]
, which assumes that things like pixel size do not change within the dataset). Although it is possible to re-order based on the time stamp, I cannot see when the arbitrary ordering will become a problem. @talonchandler can you explain the use case where this change have to happen within the reader?
from waveorder.
Thanks Ziwen, this might not be the root issue that I thought it was. I think you're right that reader.files
is only used to extract shared metadata across the dataset.
I was trying to debug an ordering issue for a collaborator (they're reporting unexpected input-output ordering from WaveorderReader
), and I thought I'd found the issue in reader.files
---at the very least it's unexpected that that reader.files
has a random order, even if it's not causing a bug.
Let's leave this open for now, and I'll report back after I get a better handle on their dataset.
from waveorder.
The root issue was a misunderstanding between Micromanager's position order and ImageJ's position order. If you drag the folder of ome.tifs into ImageJ, it will open in an order that depends on the file system. But if you drag the folder of ome.tifs into MicroManager, it will open in the "correct" MicroManager order.
WaveorderReader
opens in the same order as MicroManager, so it is opening the files in the correct order.
I will still suggest renaming reader.reader.files
to reader.reader._files
since this added an extra layer of uncertainty to my debugging. What do you think?
from waveorder.
I will still suggest renaming
reader.reader.files
toreader.reader._files
Do you want this change to happen in waveorder.io
or iohub
(or both)?
from waveorder.
Closing since this is fixed in iohub
and we're migrating soon.
from waveorder.
Related Issues (20)
- Slow birefringence reconstruction for z-stacks HOT 6
- README figure is low-res and transparent HOT 2
- `opencv-python` is taking >30 minutes to build on M1 HOT 5
- Removing I/O module HOT 5
- Migrate fluorescence reconstructions to `torch` and `model`-based structure HOT 4
- More efficient GPU compute HOT 2
- WaveOrder multipage tiff reader needs to close the tifffile after opening, otherwise a warning is thrown. HOT 1
- WaveorderReader get_array position optional HOT 1
- reconstruction with GPU seems is limited by GPU RAM
- `setup.py` includes line: `python_requies = '==3.7'`
- Rename `master` to `main`
- Replace custom CuPy implementation of SciPy APIs HOT 3
- estimate focus slice during 2D phase from brightfield reconstruction HOT 1
- Odd-sized dimensions use incorrect frequency coordinates HOT 1
- `lambda_illu`, `NA_obj`, and `NA_illu` names can be improved
- `WaveorderReader` should give more informative error messages HOT 2
- `WaveorderWriter` is not compatible with `napari-ome-zarr` reader HOT 6
- `napari.Viewer()` fails after `import waveorder` in OnDemand session HOT 1
- Bump Python version
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from waveorder.