env['http_proxy'] support about faraday HOT 6 CLOSED

It's easy to test environment variables. Before the test set the variable in ENV, and ensure that you clean up after the test has finished. If you think the variable might have an existing value, save that existing value before the test and restore it after. Easy. ENV is almost an ordinary Hash, anyway.

Is "http_proxy" environment variable some kind of existing convention?

from faraday.

How safe is it to reset the env like that. What if some other program in the background is using it? Maybe I'm being over cautious.

Is "http_proxy" environment variable some kind of existing convention?

It's certainly a *nix convention.

from faraday.

You're being over-cautious. Set it, test it, reset it.

from faraday.

:) ok

from faraday.

How safe is it to reset the env like that. What if some other program in the background is using it? Maybe I'm being over cautious.

ENV is specific to the process and won't leak to parent or even unrelated processes.

from faraday.

Thanks. I've submitted a patch with tests

from faraday.