Suggestion: return response header values as arrays since they can have multiple values about faraday HOT 6 CLOSED

I'd support a backwards-incompatible change that makes env[:response_headers] always return headers with array values. It's crazy how inconsistent (and wrong) the behavior is in some of the existing adapters.

from faraday.

Inconsistent—yes. But headers as strings are definitely more convenient to use. Imagine having to type env[:response_headers][:content_type].first or env[:response_headers][:location][0] all the time.

I'm tempted to implement something like Net::HTTP headers, where you have to use a special method to access multivalues as arrays.

Also, from the spec:

Multiple message-header fields with the same field-name MAY be present in a message if and only if the entire field-value for that header field is defined as a comma-separated list [i.e., #(values)]. It MUST be possible to combine the multiple header fields into one "field-name: field-value" pair, without changing the semantics of the message, by appending each subsequent field-value to the first, each separated by a comma. The order in which header fields with the same field-name are received is therefore significant to the interpretation of the combined field value, and thus a proxy MUST NOT change the order of these field values when a message is forwarded.

from faraday.

@mislav: Interesting. Thanks for quoting the spec. I need to read the RFCs more.

I guess the encoding issue I mentioned for using a comma-separated values is a non-issue.

I'm tempted to implement something like Net::HTTP headers, where you have to use a special method to access multivalues as arrays.

That might be worthwhile.

from faraday.

I definitely don't want every header value to be an array. I hated that shit from ASP 3.0 :)

for i=1 to Request.QueryString("n").Count
  Response.Write(Request.QueryString("n")(i)
next

from faraday.

Seems like we agreed to keep comma-separated values as String. Closing…

from faraday.

For what it's worth, this is an issue when multiple Set-Cookie headers are sent, since Set-Cookie contains a comma in the expires clause, eg.:

foo=bar; expires=Sat, 03-Nov-2012 16:37:48 GMT; path=/; domain=.example.com; HttpOnly

I thought I would solve this by subclassing the Faraday NetHttp adapter or inserting a middleware, but unfortunately the fact that joining by comma is baked into Utils::Headers makes all of that impossible. At the very least it would be nice if those of us that want an array of values had an easy and maintainable way of getting it.

This appears to be a known issue with the RFC and many client implementations, eg. Google AppEngine: http://code.google.com/p/googleappengine/issues/detail?id=3379

At this point, the only possible solution seems to be to manually parse the concatenated header using a regex that avoids splitting in the middle of the expires clause.

response.headers["set-cookie"].split(/, (?=[^;]+=[^;]+;)/)

from faraday.