lindbrook / cholera Goto Github PK

First, thanks for using elevatr in your package on CRAN. Really excited that others have found it useful.

This issue is to inform you that there are some big changes coming up shortly with elevatr. There are all around the archiving of rgdal and rgeos and the associated changes to sp and raster. I have decided to move entirely to sf and terra and am removing dependencies to rgdal, rgeos, sp, and raster. This has been implemented in the latest version on the main branch on GitHub (https://github.com/jhollist/elevatr). I have not completely removed the raster dependency and elevatr is still returning a RasterLayer from get_elev_raster. This will change in a future release and elevatr will return only sf objects for point elevation and terra SpatRasters for the elevation rasters. Given this you will need to account for this change in your packages.

I am planning on sending version 1.0, which still returns RasterLayer, to CRAN in a few days. At that point I will update the GitHub version to return SpatRasters which should allow you all to test your packages. I would expect to wait several months before sending the SpatRaster version to CRAN.

Hello,

There is a link in the duplicate.missing.cases vignette that no longer works. Perhaps you may find it useful to replace the link to https://www.ncgia.ucsb.edu/pubs/snow/snow.html (it 404s for me at least) with a Web Archive link to https://web.archive.org/web/20100703135709/http://ncgia.ucsb.edu/Publications/Software/cholera/ (with working links to the original digitised data and even BASIC source code for the map program).

I have a suggestion for slightly extending the functionality of plot.time_series, to allow passing of more arguments: "type", "lwd", "frame.plot", and "main". The reason is wanting to plot the time-series closer to the graphics of Tufte - something like the attached

SnowBroadTimeSeries.pdf

Would you be amenable to my sending you the changed code (so you can review) or my initiating a pull request?

Thomas