lectrode / quick-net-fix Goto Github PK

Need to test, as I've encountered sources that have contradicting statements on 
this issue. If XP Home edition does not support it, I will need to decide if I 
wish to rewrite portions of the script specifically to support it.

the command:
'for /f "tokens=* delims=" %%n in ('wmic nic get NetConnectionID') do call 
:EnumerateAdapters_parse %%n'

hangs. when task manager is opened, one can see 'wmic.exe' still running and 
refusing to close. this causes the entire script to hang.

wmic only does this on Windows XP Pro (Home edition does not have wmic).

Right now, if the Network Connection name has unsupported characters (such as 
&,%,!, or ^), there are no errors thrown; the script tries to continue, either 
with the wrong name, or unable to retrieve a name.

This script should at least tell the user when a name has an unsupported 
character so that the name can be changed.

The Crash alert introduced in v4.2.331 works by starting the script as a child 
instance to the main window, thereby allowing the error message to display if 
the child instance stops. if a second instance is run after the child instance 
is started, the 2nd instance cannot detect the first instance or end the first 
instance for the same reasons as issue 22.

When an issue is detected, this script will attempt to fix it using the tools 
it has. This script can only fix issues that occur between the computer and the 
device it is immediately connected to (such as a router). This is exactly what 
the script does most of the time.

However, the "fallback" addresses adds a whole new range of problems it detects 
but cannot fix. For example, it cannot fix an issue that an ISP is having and 
therefore should not detect it. If a website is down, this is not an issue it 
can fix and should not be something the script detects.

`for /f "tokens=* delims=" %%p in ('ping -w %timeoutmilsecs% -n 1 
"%testrouter%" -i 255') do (if not "%%p"=="" set /a pnum+=1&set 
"ping_test!pnum!=%%p")`

The above code is not parsed correctly in Windows Vista and earlier. 

These adapters will probably not be used by this script unless used by someone 
who knows what they're doing. Such adapters are:

-Tunnel
-VirtualBox
-VMWare


I need to find out what these adapters are generally named so I can add them to 
what is filtered out in my script

v5.0.364 
(https://code.google.com/p/quick-net-fix/source/detail?r=2a61d0296e13e81866f5608
1033295eb10c83c9b ) was a good start on this issue.

There are still some things that need to be changed to make this script fully 
support various network configurations where the networks do not have internet 
access.

For limited users I need to add the alternative of using "ipconfig /release" 
and "ipconfig /renew"


The question is, do I want to make that in addition to resetting the adapter 
when the script has administrative privileges?

There are some cases where the Gateway address will be blank in IPCONFIG 
output. When this is the case, the script should try to find the next best 
addresses to use to test connectivity.

-DNS Servers
-DHCP Server

This applies to Windows 8, 8.1, Server 2012, Server 2012 R2

When a BATCH file executes POWERSHELL on these systems, the title of the 
console window temporarily changes to "Windows Powershell" or "Administrator: 
Windows Powershell". During this brief time, any concurrent instance of the 
batch script searching for limited instances will fail to find it.

Depending on the system, the time that the window title remains changed can be 
anywhere from less than a second to 15 seconds.

Popularity of my script would increase if people could see real features and 
bug fixes and other general development signs

If an adapter is manually specified, the detected router should be limited to 
only those used by that adapter. That way, if the adapter in question has been 
disconnected, the script will attempt to fix it instead of just switching to a 
router used by another adapter.

The same problem that plagues Windows XP (issue 17) has just been confirmed to 
reek havoc on Vista systems as well. 

netsh interface set interface "[LAN Connection]" admin=[enable/disable]

has the same error in Vista as it does on XP

Even if WMIC usually works, it may infinitely hang when windows is first 
starting up. This is not usually the case, but it can be a major issue if the 
computer frequently restarts and is slow in doing so.

WMIC may also infinitely hang if it is executed too soon after the previous 
execution. Again, this is normally not the case.

This script uses "taskkill" to end a previously started instance if restarted 
with administrative privileges. However, "start /b" seems to prevent "taskkill" 
from finding the first instance given the "WINDOWTITLE". 


Removing "/b" allows the script to function as it normally would

If the script is run on a read-only device and the operating system disk is 
read-only, then there would be no temporary place for the script to write 
temporary files to.

Mini would have only basic information

Detailed would have more information than Normal

Currently, the script detects whether it has been run before by searching for a 
process with the WINDOWTITLE: "User: %thistitle%"

This search may fail if the script was run as a service, as a service may not 
have the WINDOWTITLE property. 

Not a problem with the script, but a very serious problem nonetheless. 

Linux has the ability to keep Windows Line endings in tact when text is copied 
to the clipboard. This can then be pasted to another program with no 
alterations to the original characters. Despite this, Mediafire seems to detect 
the operating system and alter the characters accordingly when a text document 
is edited online. 

Currently, if the script is run after these characters have been altered, not 
only does it fail to work as it should, it deletes itself and possibly other 
files as well. It should never get to that point.

At the very least this script should be able to detect a fatal flaw such as 
this and halt the execution without altering anything.

LAN adapters cannot be enabled/disabled via commandline in Windows XP, as that 
functionality is not included in a standard installation. This is not something 
that can be fixed without using a 3rd party tool like devcon. Support for this 
will not be added unless requested.

full IPv6 address: XXXX:XXXX:0000:XXXX:0000:XXXX:0000:0000
can be shortened to: XXXX:XXXX::XXXX::XXXX::

parsing uses ":" as delims. with that being the case, there's no way to keep 
track of where the double ":" are.


Right now, any addresses that have the double ":" anywhere except after the 
first 4 digits would not be correctly deciphered

In Windows 8 certain values that used to be stored in the global environment 
variable PATH were removed.  

This includes "%WINDIR%\System32" which is where many command line tools are 
located. In windows 8, none of the commands stored in that folder are 
accessible without including their full path, which is not something that had 
prior been included in the script

When the script first tests WMIC, it hangs. The script kills the process and 
continues and disables the use of WMIC after that.

-Needed for AutoUpdate (issue 5)

right now, the script uses 'net session' to see if the script is running with 
administrative privileges. 

unfortunately, there is a case in which this command does not work properly: if 
the lanmanserver ("Server") service is not running, it will return the same 
errorcode as when it is run on with limited privileges.

currently, this results in an infinite number of instances of the script being 
started.

either page per setting (may be preferred), or a page for each type of setting, 
or a page with all settings

Not quite sure how I'd implement this. This may require that I start a new 
project dedicated to this...

One where it would start a bunch of sub processes, one to monitor each one

AutoUpdate would automatically check for and download updates.
It would have 1 setting: Enable or Disable

I'd have to change the way the script starts...
-When the script starts, it would check for a param
-if param is "Updated" script would update title and skip initializing the 
settings...
-It'd have to have option of external settings like it's predecessor

Right now, those numbers mean very little to users of this script. I need to 
replace those with something more meaningful, namely: the length of time the 
script has been running

Windows XP and Server 2003 cannot run vbs scripts in batch scripts as a limited 
user. An attempt to run a vbs file, be it through cscript, start, or by calling 
the vbs script directly, results in "This file does not have a program 
associated with it for performing this action."

At this time, the code to request admin rights is VBScript. Unless something 
can be done to resolve or avoid this issue, Windows XP and Server 2003 systems 
will not be able to request elevation.

Even with all the settings explained, there are still somethings that people 
may want to know about my script before they use it

Applies to latest revisions (4.2.399)

This issue is closely related to issue 22 and issue 25.


Periodic check for multiple instances works most of the time, but there are 
occasions where if multiple instances are running, some will close and others 
will "crash" leaving none running. This happens especially when multiple 
limited instances are running.

Turns out, there's not much that will need to be changed to support Windows 
2000, so might as well:

-add "Network and Dial-up Connections" to what the vbs script that 
enables/disables the connection looks for

-disable use of 'sc' and 'reg' if not available

-create a blank file in %WINDIR% to see if it has admin rights

-make sure %WINDIR% is valid