Code Monkey home page Code Monkey logo

Comments (9)

le717 avatar le717 commented on August 18, 2024

/cc @rioforce I know you'll have a say in this.

from ldr-importer.

rioforce avatar rioforce commented on August 18, 2024

Not sure how we would do the persistent options, probably have to assign a number to each option and keep it in an external file. We could have a User Presets menu like we used to, but I think we had trouble with that because it messed up the LDraw path...

Use High-res bricks is always off by default. Renaming the option might work, although adding the specific details would be best in a tooltip. We'll also make an option of using Low-res bricks.

Using the original LDraw mesh might be good for LDraw CAD programs, but Blender is simply not a CAD program. It is a complete 3D modeling and rendering suite. We need to use a Blender Optimized Brick because there is lots of duplicate mesh on top of itself and it makes rendering, and editing painfully slow. Since the other LDraw CAD programs don't really use mesh, but rather coordinates in a file, they don't have messy mesh data. I think we should keep the Blender Optimized option by default.

from ldr-importer.

MinnieTheMoocher avatar MinnieTheMoocher commented on August 18, 2024

persistent options: just store them in config.py the same way as ldraw dir, that's all!
very simple!
i was just wondering why you only store the ldraw dir option there and the others not.

from ldr-importer.

le717 avatar le717 commented on August 18, 2024

I've updated the description for the high-res brick option, commit pending. How are those bricks officially referred to? I was also going to update the label, but I wasn't sure if "Use High-res (48ed) bricks" was correct or not.

The other import options were not stored in config.py because we were trying to ease the biggest (aside from the recursive class issues) issue with the script. It is completely possible to store the rest of the settings in it. I'll have to remember how we did it exactly, but this certainly can be done.

Assigned to milestone v1.2.

from ldr-importer.

MinnieTheMoocher avatar MinnieTheMoocher commented on August 18, 2024

They are not bricks. They are primitives.

Brick files use them in their implementation.

They are called High-Res Primitives.

What your option does is it toggles whether bricks using primitives
get the "normal" default resolution primitives, or, instead, always the high-res version.

IMHO the option should be called "Replace all primitives by High-Res versions".
That's what it actually does.

from ldr-importer.

le717 avatar le717 commented on August 18, 2024

I updated the button label in d29cb9e, tell me if that is correct now. I could not display "Replace all primitives by High-Res versions" because it was too long.

from ldr-importer.

le717 avatar le717 commented on August 18, 2024

I switched the milestone to v1.1.6 because this can be solved by re-enabling Blender presets (6d07dff8dd). However, this may create a conflict with the auto-detected/stored installation path on Windows (at least for this code base, #60 would not be affected, and neither would Mac OS X and Linux). I'll run some tests and see what happens.

from ldr-importer.

le717 avatar le717 commented on August 18, 2024

Per #66, reassigning to v1.3.

from ldr-importer.

le717 avatar le717 commented on August 18, 2024

Import options are now preserved by way of Blender operator presents (#65, 07ffba5). It will be present in the next release. Thanks for reporting this, @MinnieTheMoocher. 😃

from ldr-importer.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.