Code Monkey home page Code Monkey logo

plasma-applet-redshift-control's People

Contributors

alessandromenti avatar archangegabriel avatar gszy avatar icaroperseo avatar kotelnik avatar mrueg avatar naund avatar ntninja avatar odyx avatar psi57 avatar s8321414 avatar szpadel avatar travmurav avatar

Stargazers

 avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar

Watchers

 avatar  avatar  avatar  avatar  avatar  avatar

plasma-applet-redshift-control's Issues

[miniature pannel] Change on click

Currently, in the miniature pannel, clicking opens a popup where there is just one icon... It would be better, not to popup anything.

When you click, it change the status.

Does not work with KDE in Fedora 28

I just installed this on my Fedora 28 laptop, and when I click on the widget in my taskbar I get an error window popup: "/bin/sh: redshift: command not found". The command locate redshift does not show any such file in my system, although I do see for example:

/home/schwager/.kde/share/apps/plasma/plasmoids/org.kde.redshiftControl/contents/config/main.xml

I installed by doing

plasmapkg -u ~/Downloads/*.plasmoid

Because pressing the "Install" button from Konquerer gives me a complaint that Konqueror has no handler for .plasmoid files.

Show popup

This is an applet for KDE Plasma, because of that, I think it should have a popup, like plama-nm and plama-pa. My recommendation is adding sliders controls to temperature and brightness (additionally to scroll wheel), and to change the current mouse left-click to middle one, like plama-pa does for muting and unmuting.

Preserve color doesn't work as it should

Hi, I use a custom .icc profile, running redshift from a command line works good but the applet seems to mess with it, the preserve option doesn't work, either in randr mode or vidmode the .icc is ignored even if it is running in daytime.

borked with recent updates to neon

Operating System: KDE neon 5.14
KDE Plasma Version: 5.14.5
Qt Version: 5.11.2
KDE Frameworks Version: 5.54.0
Kernel Version: 4.15.0-45-generic
OS Type: 64-bit

the plasmoid is loading two of itself:

image

it also flickers from on and off when you log into a new session until i go in and change toggle the location setting on and off again. seems to fix it.

Error running Redshift command

I have installed this plasmoid on OpenSUSE TW but when the plasmoid is installed immediately I get the following error:
Error running Redshift command
/bin/sh: redshift: could not find the order

Do I need some additional?

better handling of manual adjustment

The scroll-wheel effect that manually overrides the auto settings should:

  • start at the current setting (whatever that is) and go redder or bluer from there (depending on scroll direction). Currently it jumps back to 6500 and then adjusts from there.
  • revert to the auto settings when the icon is clicked. Currently, it turns off when clicked, requiring two clicks to cycle from manual-override to off and then back on to auto.

Obsolete advanced options screen

Good morning,

mode settings on the screenshot below is obsolete. The preserve option does not work and screen option is missing.

screenshot1

# redshift -m list
Available adjustment methods:
  drm
  randr
  vidmode
  dummy

Specify colon-separated options with `-m METHOD:OPTIONS'.
Try `-m METHOD:help' for help.
# redshift -m drm:help
Adjust gamma ramps with Direct Rendering Manager.

  card=N        Graphics card to apply adjustments to
  crtc=N        CRTC to apply adjustments to

# redshift -m randr:help
Adjust gamma ramps with the X RANDR extension.

  screen=N      X screen to apply adjustments to
  crtc=N        CRTC to apply adjustments to

# redshift -m vidmode:help
Adjust gamma ramps with the X VidMode extension.

  screen=N      X screen to apply adjustments to

# redshift -m dummy:help
Does not affect the display but prints the color temperature to the terminal.

As we can see, there are three options: card, screen and crtc. None of them are available in the plasmoid. I find screen option very useful when using projector as a second display.

redshift version:  1.10
plasmoid version:  1.0.12-1
(both from Debian packages)

Thank you and have a nice day!

System Tray no logner works in Plasma 5.12+

takomora on the KDE Store: "The Redshift item in the System Tray no longer works in KDE Plasma 5.11.95 (5.12 beta). I really liked the System Tray entry feature of this, so hopefully that can be fixed in the future?"

Please specify license in the source

While packaging this applet for Debian, it got noticed that the license is not overly explicit; could you add a LICENSE fie at the root of this package?

Plasma crash with Qt 5.8

There are recent changes in Qt 5.8 due to QFontEngineFT and they seem to let the Redshift applet crash the Plasmashell, when you move the panel from the side to the top/bottom.

Resizing the panel works fine.

https://gist.github.com/ShalokShalom/7448ebf25e0309f8a353620b1ad92d1e

Issue is not reproduceable with Qt 5.7, so here are the changes in qt5-base since then:
http://code.qt.io/cgit/qt/qtbase.git/tree/dist/changes-5.8.0

(By the way, v1.0.16 without the new translation is currently the freshest version in kde store:
https://store.kde.org/p/998916)

Two clashing redshift processes if systemd's startup of redshift isn't masked

On Kubuntu 21.04, once the "redshift" package is installed, then by default, systemd will automatically start redshift, and will even promptly restart it again if you kill the process. (Kubuntu 20.10 and earlier did not do this by default). Since this is due to an update of the redshift package, I assume that this will be the default on other recent linux distros too.

If this applet is then installed via "Get new widgets" (I hope that it will become a default widget since it's being moved to phabricator) then it will start another redshift process causing the screen to flash color changes every second or two.

To "mask" (i.e. permanently disable) the systemd startup of redshift for the current user, issue this command:

systemctl --user mask redshift

Details:

The installation of version 1.12-4 of the redshift package creates a link that instructs systemd to start redshift:

/etc/systemd/user/default.target.wants/redshift.service -->
    /usr/lib/systemd/user/redshift.service

This link can be removed with the following command:

sudo systemctl --global disable redshift

Or this can be overridden and disabled for a single user with:

systemctl --user mask redshift

Which creates a link:

~/.config/systemd/user/redshift.service --> /dev/null

I assume that the easiest way to fix this problem is to have this applet create the above link.

Redshift is turned off when I log in

I have Redshift Control V1.0.16 installed from KDE-Apps.org (using Plasma's widget explorer) and when I log in, Redshift is disabled although Autostart is checked in the plasmoid settings.

I am using Plasma 5.6.4 under Manjaro Linux.

Current temperature and geoclue2 support

Thanks for your work! this is awesome project!
I have 2 feature requests that may help to make this plasmoid even more awesome.

First one is preview of current color temperature.
It would be nice to have it in the tolltip of the plasmoid.
(You have read current temperature using redshift -p or you can parse output of redshift -v (I think this is more elegant solution))
https://github.com/jonls/redshift/blob/master/src/redshift-gtk/statusicon.py#L176

Second it support for geoclue2 to automatically detect current location.
This would be nice feature for peope who travel frequently.

Best Regards
Piotr

Multiple screen adjusts support

I have two screen and at same software temperature they have different blu/red level, seems to me that redshift support having custom temperature for each screen, but this seems not configurable by the applet, is there any plan to support this in near future?

Temperature and brightness only reducing when using scroll wheel

When trying to adjust the temperature and brightness using the scroll wheel hovering the applet icon, both are effectively reduced no matter if I scoll up or down. The numbers (Kelvin and brightness 0-1) seems to adjust in the right direction but the effect is reduced brightness and increased red-levels until screen is impossible to see.

The applet get the wrong time.

Hello,I am happy to hear of you new applet.But It get the wrong time.(for example It'night now but the applet think it's day now.)
Maybe because of time zone.

Middle click switch between kelvin and brightness

I find my self adjusting the brightness very often, and it is a bit of a hazzle to open the settings panel to do it. How about middle clicking the icon switches modes between kelvin and brightness so that both can quickly be adjusted by using the mouse wheel?

New instance of redshift is executed if plasma crashes

When plasma crashes and restart, a new instance of redshift is executed causing interference with the previous one, i.e., the color of the screen starts to flicker. There should be a check to verify that other instances of redshift are not already running, and possibly kill them before lunching a new instance or try to use the running instance.

Step to reproduce it:

kquitapp5 plasmashell
plasmashell

fr translation mistake

Hi,

Thanks for this nice applet. I'd like to pinpoint an issue with the french translation for the fedora 26 package. It's not "enclanché/déclanché" mais "enclenché/déclenché" and actually I would rather say something else. is this the right place to mention it? If not, where should I go?

Request: add option to preserve gamma corrections

Hi, in Redshift 1.11 an option was added to take current gamma correction into account: https://github.com/jonls/redshift/releases
It's not that greatly documented, but it works just right and fixes problem of ignored color profiles. It's invoked as additional parameter passed with correction mode setting: redshift -m randr:preserve=1. My request is to allow plasmoid to start redshift with this parameter, because currently widget is unusable when custom screen color profiles are configured.

sometimes loses settings

I'm not sure when it happens, but I've had the control widget successfully stay as set ever after some log out or reboot or something. But I've also had it lose the settings several times. Not sure if it's when I adjust something in my plasma panel or upon physical reboot of the machine or what. Anyway, there's definitely an issue where settings can be lost. I would guess they aren't being stored in a reliable config file.

Smooth modification

It would be great if the modification from normal light to red and vice-versa was smooth so that it doesn't seem so agressive.

Nice job anyway

Does not get as red as it should

I have it set to go to 1500K at night. It does not do that on its own, though. If I mouse over the system tray lightbulb, it will say it's at 1500K, but if I adjust it even one tick with my scrollwheel, or click it off and back on again, the screen will suddenly get much redder. It's as though it's unable to redden past a certain point by itself.

Widget no longer appears as entry in System Tray

I am currently running OpenSUSE Tumbleweed, which recently updated KDE Plasma to 5.11.95 (aka 5.12 LTS beta). Since I rebooted after the install at night, I immediately noticed Redshift was not working. I can still use the widget if I place it as a separate widget in the taskbar, but it will not appear as one of the icons in the system tray and is no longer listed on the available entries to enable.

Is there some way I can fix this? How would I diagnose the issue? Is it possible it will be fixed when the stable release of KDE Plasma 5.12 comes out?

redshift print finished with code 0, but not matched the regex

The following message is printed to my systemd log every 10 seconds:

plasmashell[22250]: qml: redshift print finished with code 0. sourceName: redshift -t 6500:4000 -b 1:1 -g 1:1:1 -r -p, data: Dienst »geoclue2« wird benutzt.
Zeitraum: Übergang (85.38% day)
Farbtemperatur: 6134K
Helligkeit: 1.00
, but not matched the regex

Is it because the output is localized? How can I change this?

Breaks desktop notifications on Kubuntu 16.04 with KDE Plasma 5.8.9.

I love this applet, however, on Kubuntu 16.04 with KDE Plasma 5.8.9 this applet breaks all desktop notifications at least from Slack and Google Chrome, they simply stop showing up. Removing the applet makes notifications work again.

I also use the applet on another machine with Kubuntu 18.04 and latest updates. No issues there.

icon too big

For my specific settings (ubuntu wily, plasma 5.4.3, screen resolution 3200x1800) if I add the plasmoid to a panel the icon is far too big. I solved the problem by:

a) using font.pixelSize instead of font.pointSize and
b) making the size of the icon dependent on the minimum of the parents' width and height (instead of asking for vertical)

very high plasmashell/kwin cpu load when using geoclue

Lately, my laptop (up-to-date plasma/kwin on intel from Arch/Manjaro) started becoming sluggish (and hot...) after some time. Restarting plasmashell helped for some time.

After trying out lots of stuff, I found out that the automatic location identification of redshift using geoclue2 was the culprit. Setting the location manually and disabling geoclue made my desktop usable and nicely reddish again ;-)

Since geoclue was not bubbling to the top in htop, it took a while to come to this solution. Perhaps there is some kind of deadlock inside of redshift when it tries to communicate with geoclue? Just wanted to report that finding, as there are many questions online where people are wondering, why their desktop crawls to an halt.

Autostart not working with Kubuntu 16.04

Using Plasmoid 1.0.18, Kubuntu 16.04, KDE Plasma 5.8.7, KDE Frameworks 5.36.0, Qt 5.6.1.

Redshift works fine when I click on the plasmoid, but it never starts automatically despite the autostart option being checked. I tried reinstalling, reapplying the autostart option, but it does not change anything.

I see the following in .xsession-errors, which shows it tries to start but maybe it's killing the process right afterwards:

qml: disabling redshift
qml: renderModeString: 
qml: disabling redshift
[...]
qml: clearing connected sources, stop source was: killall redshift; redshift -x
qml: enabling redshift with command: redshift -l [coordinates] -t 6500:4000 -b 1:0.8 -g 1:1:1

Themed or Custom Icon Support

Hi,

Thanks for this applet!

I'd like the option to use status icons from the user's icon theme, rather than fontawesome -- or simply custom icons, one for each status.

At least on Arch, the redshift package itself includes

/usr/share/icons/hicolor/scalable/apps/redshift-status-{on,off}.svg

And I can see that some other icon themes have the same-named icons as well, like

/usr/share/icons/Numix/{16,22,24}/panel/redshift-status-{on,off}.svg
/usr/share/icons/Papirus-GTK/{22x22,24x24}/panel/redshift-status-on.svg

Scrollwheel kills plasma

Heavy issue. I just had my plasma session unrestoreable by reboots and launching it from Konsole by simply scrolling with the mousewheel over the widget.

I already had the first part of the issue before, while not the entire kill.
First issue was, that plasma-widget-redshift turned my screen darker and darker, in huge steps and ANYWAY in which direction I moved the wheel.

Then, this time, plasma disappeared after a restart of the whole system entirely.

Allow to disable geoclue

My system usually starts without networking (due to a misconfiguration somewhere, I need to give kwallet my password before it starts the Wi-Fi, but that's another topic). Anyway, it makes Redshift Control fail at each Plasma session start since geoclue can't find the network.

It would be nice if the geolocation could be made optional in the settings, and when disabled, only the manually specified coordinates would be used.

Is it possible to determine current screen color temperature via command line?

Is there any way to determine the current color temperature that has been set by redshift-control? For example within a shell-script? I tried 'redshift -p' but this always displays color temperature 5.500 K even when it is set to a different value in redshift-control. Does redshift-control have any interface that could be used?

No longer has temporary disable "lightbulb" control in Plasma 5.5.5

redshift_no_controls

  1. OS: Fedora 23 full updated
  2. plasma-desktop-5.5.5-1.fc23.x86_64
  3. Redshift still works, options from the settings menu still work.
  4. Control is not simply invisible, click action in "correct" area also does nothing.
  5. Searched journalctl for some errors, nothing
  6. ~/.xsession-errors had:
    file:///home/xenith/.local/share/plasma/plasmoids/org.kde.redshiftControl/contents/ui/main.qml: QML Plasmoid: Cannot anchor to an item that isn't a parent or sibling.
    but that seems pretty normal and benign, i've seen it before on F23 pretty often with other applets

Location setting lost on reboot irregularly

Sometimes the saved latitude and longitude are reset to the default values.

This does not happen every time, and I can't yet find any pattern.
I suspected it might happen when I boot the computer and log in with no network connection,
but I just tested this and the settings were saved this time.

Computer info:
Hardware: Lenovo X250 (Core i5, gen 5)
OS: Kubuntu 16.04 (using kubuntu-backports PPA)
KDE: Plasma 5.6.5, Frameworks 5.23.0, Qt 5.5.1

IIRC the problem occurred on stock Kubuntu 16.04 as well.

Custom ICC Profile

Hey,
I wish I could use some custom profiles when redshift is turned off.
It would be great if the applet could handle it by itself, however, an option to run custom scripts when redshift is off would be also sufficient. Then I would call xcalib...
I hope this is feasible.
Thank you

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.