dns-lookup are failed to compile on Windows about dns-lookup HOT 6 CLOSED

@dilawar socket2 v0.4.5 has been yanked.

from dns-lookup.

Came here to report exactly the same issue. Looks like socket2 is not playing well with https://microsoft.github.io/windows-docs-rs/doc/windows/Win32/Networking/WinSock/struct.SOCKADDR.html# (or vice-versa).

@bachue Please let me know if you find a way around it e.g. pinning versions.

from dns-lookup.

Thanks for the bug report.

I might keep this issue open for now until socket2 have decided what they want to do, this crate may need changes if they release a new version. I'll also consider if I should switch to windows_sys myself (though it still appears to be quite new, and a fast moving target).

from dns-lookup.

I'll also consider if I should switch to windows_sys myself (though it still appears to be quite new, and a fast moving target).

I am porting this to windows_sys on our fork. I am new to Rust though but I'll link my work here anyway. It may be helpful 🤞🏼. One super annoying change in windows-sys crate is u8 and i8 are mixed and I am scared of std::mem::transmute.

winapi is not actively maintained so probably it is not a bad idea porting to windows_sys.

from dns-lookup.

I've merged a version with the migration to windows-sys, along with a few fixups to work with the latest socket2. The windows github actions are passing, but I'd appreciate if someone could test this with a real windows application. Once I get confirmation I'll push version 2.0.0.

from dns-lookup.

I've done some testing on Windows and it all looks good, so I've pushed version 2.0.0 with the windows-sys changes.

from dns-lookup.