Type safety, family about dns-lookup HOT 2 CLOSED

Hi, thanks for the feedback.

At this point I'm not going to rename the field. This would change the public api, causing unneeded churn for downstream users. I think reordering them should be fine (I'll need to look into this), and I'll update the documentation so it's clearer that it's actually address family.

Regarding ints for the hints field, this is intentional. Different libc implementations offer different socket types, address families etc, so it's hard to offer a single Enum that can be used for every libc. Instead of trying to track every libc implementation it's easier to offer the field as an int, and let the programmer worry about different libc implementations. So this crate worries about safety with regards to pointers and C-isms, while offering getaddrinfo (and friends) as directly as possible.

(There is a way around the above by using generics with Into - https://doc.rust-lang.org/std/convert/trait.Into.html#examples - I might have a look at how easy this is to implement, and if it's compatible with existing calls).

from dns-lookup.

I've pushed some changes to address these concerns.

from dns-lookup.