Comments (5)
ofirshtrull
commented on July 2, 2024
1
I honestly to remmber this at all,
And i dont work at the same company any more
from github-pr-comment-build-plugin.
ofirshtrull
commented on July 2, 2024
and maybe have a way to set env variables with labels as a nice feature?
from github-pr-comment-build-plugin.
bluesliverx
commented on July 2, 2024
Did you set up the hooks properly and add the property to the job config?
The env variables would be a separate issue, I believe there may already be one asking for env vars actually.
from github-pr-comment-build-plugin.
Gregy
commented on July 2, 2024
The problem here is that Jenkins doesn't create the webhooks correctly on it's own. We use github multibranch pipeline job and it usually creates the webhooks github-side on it's own. Unfortunatelly it doesn't ask github to send the review statuses so the review trigger doesn't work unless you check the "Pull request review comments" event by hand in the github webhook settings. And this change gets undone when Jenkins recreates the webhook so you have to redo it from time to time.
from github-pr-comment-build-plugin.
bluesliverx
commented on July 2, 2024
@ofirshtrull is your problem described by @Gregy? I'm not sure what it would take to add webhooks and don't have time to look at this at the moment. PRs are absolutely welcome though if someone has else the time.
from github-pr-comment-build-plugin.
Related Issues (20)
- Question - Github App Authentication - Does it work? HOT 2
- Job is triggered twice with this plugin HOT 3
- Better Support for Job DSL configuration of GitHub Organization Folder HOT 2
- The plugin is not triggered with a multibranch pipeline HOT 2
- This plugin triggers the build twice HOT 8
- not able to retrieve getCommentBody or getCommentURL from currentBuild.buildCauses HOT 11
- Unable to trigger build with wildcard in the comment body HOT 2
- Does the latest version support trigger building in multibranch pipeline project? HOT 3
- plugin doesn't trigger a build when a PR comment is issued HOT 2
- Restrict build trigger to project group members HOT 14
- Trigger more than one job with single PR comment HOT 1
- isAuthorized() throws an exception when it should return false
- Comment text as env-var to job HOT 1
- Please give some example pipeline code in the README
- Triggerring more than one job with single PR comment is broken HOT 6
- what is a "trusted" user as defined by this plugin HOT 16
- Thumbs up/down on successful/failed submission HOT 8
- Document the requirement for branch discovery behavior HOT 4
- For private repositories people with Read role can trigger builds HOT 1
- The plugin triggers builds for PRs with same number in different repositories HOT 4
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from github-pr-comment-build-plugin.