Comments (4)
Definitely not intended behavior. Trying to figure out what is different in your setup though, since we don't hit this problem and we have thousands of PRs across hundreds of repositories.
from github-pr-comment-build-plugin.
Ah, I missed originally that this is for a GitHub Organization Folder job. How did you configure this plugin for the folder? See also #1 as this describes some of what might be involved. Otherwise I think you are the first one (or the first to report) to try this.
from github-pr-comment-build-plugin.
Hello,
Thank you for the fast reply!
In the Jenkins organization folder, we just have the following (relevant?) settings:
I think these are the most relevant ones. I also have "Pull request" event configured in the Github webhook, and if I remove the "Trigger build on PR comment", a build will be triggered if I update one of the PRs, but it will trigger only for the relevant repo.
I had a quick look in the plugin code, as I was looking for the "Triggered build for <...>" source (from the log snippet), and if I interpreted it correctly, it will get all jobs, and if it matches the PR number, and the configured keyword, it will start a build:
https://github.com/jenkinsci/github-pr-comment-build-plugin/blob/fef405665ee23acb44dea17ec12a36a887c58153/src/main/java/com/adobe/jenkins/github_pr_comment_build/IssueCommentGHEventSubscriber.java#L138C42-L138C42
from github-pr-comment-build-plugin.
I believe this is a misconfigured. As mentioned in #1, the trigger must be added in the Jenkinsfile and not on the organization folder itself. I think what is happening (just a guess though without actually seeing the config) is that the folder is the GitHubSCMSource and since it has the property on it, it triggers everything underneath it.
from github-pr-comment-build-plugin.
Related Issues (20)
- Question - Github App Authentication - Does it work? HOT 2
- Job is triggered twice with this plugin HOT 3
- Better Support for Job DSL configuration of GitHub Organization Folder HOT 2
- The plugin is not triggered with a multibranch pipeline HOT 2
- This plugin triggers the build twice HOT 8
- not able to retrieve getCommentBody or getCommentURL from currentBuild.buildCauses HOT 11
- Unable to trigger build with wildcard in the comment body HOT 2
- Does the latest version support trigger building in multibranch pipeline project? HOT 3
- plugin doesn't trigger a build when a PR comment is issued HOT 2
- Restrict build trigger to project group members HOT 14
- Trigger more than one job with single PR comment HOT 1
- isAuthorized() throws an exception when it should return false
- Comment text as env-var to job HOT 1
- Please give some example pipeline code in the README
- Triggerring more than one job with single PR comment is broken HOT 6
- what is a "trusted" user as defined by this plugin HOT 16
- Thumbs up/down on successful/failed submission HOT 8
- Document the requirement for branch discovery behavior HOT 4
- For private repositories people with Read role can trigger builds HOT 1
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from github-pr-comment-build-plugin.