Thumbs up/down on successful/failed submission about github-pr-comment-build-plugin HOT 8 OPEN

@bluesliverx I can have a look at this myself. Although the flow of IssueCommentGHEventSubscriber is a bit of a mess.
I think I'll trade off for just the thumbs up for now.

from github-pr-comment-build-plugin.

Parsing the event and getting the comment to react to seems to be easy enough.
Wrote some code quickly to demonstrate.

// Add another helper method to GithubHelper
public static GitHub getGitHub(@Nonnull final Job<?, ?> job) throws IOException {
    final SCMSource scmSource = SCMSource.SourceByItem.findSource(job);

    if (scmSource instanceof GitHubSCMSource) {
        final GitHubSCMSource gitHubSource = (GitHubSCMSource) scmSource;
        final StandardCredentials credentials = Connector.lookupScanCredentials(
                job,
                gitHubSource.getApiUri(),
                gitHubSource.getCredentialsId()
        );
        return Connector.connect(gitHubSource.getApiUri(), credentials);
    }

    throw new IllegalArgumentException("Job's SCM is not GitHub.");
}

private void reactScheduled(final Job<?, ?> job, final String payload) {
    try {
        final GitHub gitHub = GithubHelper.getGitHub(job);
        final IssueComment event = gitHub.parseEventPayload(new StringReader(payload), IssueComment.class);
        event.getComment().createReaction(ReactionContent.PLUS_ONE);
    } catch (final IOException e) {
        LOGGER.log(Level.WARNING, "Could not react to triggering comment", e);
    }
}

Do you think this will work?

from github-pr-comment-build-plugin.

I'm not sure about this, mainly due to the credentials used. Sometimes they may have write access and the ability to comment, which I believe this needs. Other times it may not have the permissions.

Personally, a thumbs up is just as significant as the job itself starting and adding a check (which is how we're setup). I realize not all jobs may add/update the check immediately though.

from github-pr-comment-build-plugin.

@bluesliverx just installed and tried on our Jenkins instance. Works perfectly, and we are using auth via a GitHub App.

from github-pr-comment-build-plugin.

Obviously you'd need to set read & write permissions to comments.

Personally, a thumbs up is just as significant as the job itself starting

Rationale is without feedback I don't know if the job has started because of my comment or because of something else.
Especially in complex environments where multiple apps are used, jobs might be triggered for different reasons.

I would at least want to know if the comment has been received and interpreted correctly.

from github-pr-comment-build-plugin.

I tried with the "Read-only" permission to comments. Works ok!

from github-pr-comment-build-plugin.

Ah, interesting. I still feel like this behavior should be hidden behind a checkbox or something on the behavior dialog next to the pattern that it should match. Something like "React with thumbs up on successful comment match"

from github-pr-comment-build-plugin.

@bluesliverx agree. Someone might not want this.
I'm not an expert in Jenkins plugins, but the plugin already has UI elements luckily.

from github-pr-comment-build-plugin.