Comments (14)
vyzigold
commented on August 20, 2024
1
This is a great suggestion. It would help me a lot too.
from github-pr-comment-build-plugin.
lprimak
commented on August 20, 2024
1
Right now this change doesn’t support teams however this is a good suggestion I’ll implement it.
the functionality can be turned off currently as well
from github-pr-comment-build-plugin.
snorlaX-sleeps
commented on August 20, 2024
1
@lprimak thanks for implementing the change, means I can keep using the plugin :)
from github-pr-comment-build-plugin.
snorlaX-sleeps
commented on August 20, 2024
1
@lprimak change looks good, able to disable the new functionality.
Couldn't figure out why my PR's weren't triggering this morning xD
from github-pr-comment-build-plugin.
lprimak
commented on August 20, 2024
Any chance this gets escalated a bit? Thanks!
from github-pr-comment-build-plugin.
bluesliverx
commented on August 20, 2024
Hmm, how would you suggest this is done? I haven't been in this area for a long time and I'm fuzzy on what the configuration even looks like at the moment.
from github-pr-comment-build-plugin.
lprimak
commented on August 20, 2024
Something similar to this in the https://plugins.jenkins.io/basic-branch-build-strategies plugin:
Docs here: https://github.com/jenkinsci/basic-branch-build-strategies-plugin/blob/master/docs/user.adoc
from github-pr-comment-build-plugin.
lprimak
commented on August 20, 2024
Or, better yet, this:
https://github.com/jenkinsci/pipeline-github-plugin#issuecommenttrigger
from github-pr-comment-build-plugin.
lprimak
commented on August 20, 2024
In progress
from github-pr-comment-build-plugin.
lprimak
commented on August 20, 2024
Well tested and ready to go!
from github-pr-comment-build-plugin.
snorlaX-sleeps
commented on August 20, 2024
We are using this plugin because https://github.com/jenkinsci/pipeline-github-plugin#issuecommenttrigger doesn't support Github teams as collaborators, only individually added users (which blocks operating at scale)
Can you ensure the change supports teams and individual users, similar to https://github.com/jenkinsci/pipeline-github-plugin/pull/111/files#diff-f28baadffa29cdf918bc3cf814038606eb0abab1e61dfe9e380b50aafe020d74R39 (which may take a long time to release), or that the new functionality can be disabled please?
from github-pr-comment-build-plugin.
lprimak
commented on August 20, 2024
@snorlaX-sleeps testing this change now... should be good in an hour :)
from github-pr-comment-build-plugin.
lprimak
commented on August 20, 2024
it's done...simple stuff
from github-pr-comment-build-plugin.
lprimak
commented on August 20, 2024
@bluesliverx please review... thank you!
from github-pr-comment-build-plugin.
Related Issues (20)
- Job is triggered twice with this plugin HOT 3
- Better Support for Job DSL configuration of GitHub Organization Folder HOT 2
- The plugin is not triggered with a multibranch pipeline HOT 2
- This plugin triggers the build twice HOT 8
- not able to retrieve getCommentBody or getCommentURL from currentBuild.buildCauses HOT 11
- Unable to trigger build with wildcard in the comment body HOT 2
- Does the latest version support trigger building in multibranch pipeline project? HOT 3
- plugin doesn't trigger a build when a PR comment is issued HOT 2
- Trigger more than one job with single PR comment HOT 1
- isAuthorized() throws an exception when it should return false
- Comment text as env-var to job HOT 1
- Please give some example pipeline code in the README
- Triggerring more than one job with single PR comment is broken HOT 6
- what is a "trusted" user as defined by this plugin HOT 16
- Thumbs up/down on successful/failed submission HOT 8
- Document the requirement for branch discovery behavior HOT 4
- For private repositories people with Read role can trigger builds HOT 1
- The plugin triggers builds for PRs with same number in different repositories HOT 4
- Pull requests that are closed/re-opened do not trigger on comment
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from github-pr-comment-build-plugin.