Comments (9)
bluesliverx
commented on August 20, 2024
1
@jebentier, I finally got the build fixed, if you could take a look at my comments on the PR we can get this merged in.
from github-pr-comment-build-plugin.
bluesliverx
commented on August 20, 2024
Glad you like the plugin, it satisfied a need for us for sure. Hmm... not sure why comment URL wouldn't be able to be retrieved. Can you send the exact code you are using to access it?
I like the idea of adding another env var, but unfortunately that's a bit out of my wheel house, and may need some additional classes/extension points (I'm really not sure). It may be possible to override this when you schedule the job run, but I really don't know. PRs are absolutely welcome and encouraged, since I likely don't have any time to get to this soon just due to other work concerns.
from github-pr-comment-build-plugin.
jebentier
commented on August 20, 2024
@bluesliverx I've been using this plugin for quite some time and love the power that it adds to my GitHub repositories.
I've been looking to build out a workaround to gain access to the comment body that triggered the build for a few days now. With the code the way it is now, I've gone the route that you suggested through getting the comment URL from the build cause object. I think it will be a great improvement to this plugin (like you also mentioned) to allow access to the comment body itself through the cause object as well. So I've opened up #25 to do just this, and I've opened JENKINS-63938 in the Jira to track this issue further as well.
This is my first time contributing to Jenkins or a plugin, so please let me know if there is anything else I should do.
from github-pr-comment-build-plugin.
bluesliverx
commented on August 20, 2024
Thanks so much for the contribution @jebentier, sorry this has taken me so long to get to it. The build has failed, I'm still looking into why, likely Jenkins build made some updates (unrelated to your changes) that I haven't incorporated yet or something.
from github-pr-comment-build-plugin.
bluesliverx
commented on August 20, 2024
I believe I just released version 2.2 that should have these fixes in them. It's been awhile since I released, so we'll see if that worked after a couple of hours...
from github-pr-comment-build-plugin.
bluesliverx
commented on August 20, 2024
Yup, that seems to have worked, let me know if the new version works out or now.
from github-pr-comment-build-plugin.
jebinjeb
commented on August 20, 2024
is this env available env.GITHUB_PR_COMMENT ? or any other way to get PR comments ?
from github-pr-comment-build-plugin.
bluesliverx
commented on August 20, 2024
Currently environment variables are not supported (PRs are welcome), but you can do it through retrieving the causes on the build and look for this one: https://github.com/jenkinsci/github-pr-comment-build-plugin/blob/master/src/main/java/com/adobe/jenkins/github_pr_comment_build/GitHubPullRequestCommentCause.java.
from github-pr-comment-build-plugin.
bluesliverx
commented on August 20, 2024
Closing this issue since I haven't heard back from @conf or @jebentier.
from github-pr-comment-build-plugin.
Related Issues (20)
- Question - Github App Authentication - Does it work? HOT 2
- Job is triggered twice with this plugin HOT 3
- Better Support for Job DSL configuration of GitHub Organization Folder HOT 2
- The plugin is not triggered with a multibranch pipeline HOT 2
- This plugin triggers the build twice HOT 8
- not able to retrieve getCommentBody or getCommentURL from currentBuild.buildCauses HOT 11
- Unable to trigger build with wildcard in the comment body HOT 2
- Does the latest version support trigger building in multibranch pipeline project? HOT 3
- plugin doesn't trigger a build when a PR comment is issued HOT 2
- Restrict build trigger to project group members HOT 14
- Trigger more than one job with single PR comment HOT 1
- isAuthorized() throws an exception when it should return false
- Comment text as env-var to job HOT 1
- Please give some example pipeline code in the README
- Triggerring more than one job with single PR comment is broken HOT 6
- what is a "trusted" user as defined by this plugin HOT 16
- Thumbs up/down on successful/failed submission HOT 8
- Document the requirement for branch discovery behavior HOT 4
- For private repositories people with Read role can trigger builds HOT 1
- The plugin triggers builds for PRs with same number in different repositories HOT 4
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from github-pr-comment-build-plugin.