Comments (4)
daniel1608
commented on July 20, 2024
+1
None of our pull requests start with PR and therefore the plugin doesn't trigger the pipeline.
Are there any plans to not hardcode the pattern? How about one can set the pattern manually for each pipeline?
from github-pr-comment-build-plugin.
bluesliverx
commented on July 20, 2024
These event handlers receive all events. So this ensures that it matches a PR job named the same as the PR number. Otherwise you could have a branch named mybranch1 and it would match PR 1, etc. I'm happy to allow for modifying this in the configuration, but I don't have the time to implement it myself. Pull requests are welcome to implement this.
from github-pr-comment-build-plugin.
okainov
commented on July 20, 2024
So this ensures that it matches a PR job named the same as the PR number. Otherwise you could have a branch named mybranch1 and it would match PR 1, etc.
That sounds really weird... So this also means that it's required to have previous job? This will not work, when want to trigger some one-time job (like "deploy", for example) which was not triggered before...
from github-pr-comment-build-plugin.
bluesliverx
commented on July 20, 2024
@okainov, I'm not sure where you got anything about a previous job from. I didn't mention anything about previous job runs vs one-offs.
All I was saying is that the pattern is there to make sure that the events received for a PR match the job that is for that PR (and no other jobs), we use that regex. If the jobs are named something else, that's something that needs to be configured. However, I still don't have time to pick this up, but would welcome any contributions from the community.
from github-pr-comment-build-plugin.
Related Issues (20)
- Question - Github App Authentication - Does it work? HOT 2
- Job is triggered twice with this plugin HOT 3
- Better Support for Job DSL configuration of GitHub Organization Folder HOT 2
- The plugin is not triggered with a multibranch pipeline HOT 2
- This plugin triggers the build twice HOT 8
- not able to retrieve getCommentBody or getCommentURL from currentBuild.buildCauses HOT 11
- Unable to trigger build with wildcard in the comment body HOT 2
- Does the latest version support trigger building in multibranch pipeline project? HOT 3
- plugin doesn't trigger a build when a PR comment is issued HOT 2
- Restrict build trigger to project group members HOT 14
- Trigger more than one job with single PR comment HOT 1
- isAuthorized() throws an exception when it should return false
- Comment text as env-var to job HOT 1
- Please give some example pipeline code in the README
- Triggerring more than one job with single PR comment is broken HOT 6
- what is a "trusted" user as defined by this plugin HOT 16
- Thumbs up/down on successful/failed submission HOT 8
- Document the requirement for branch discovery behavior HOT 4
- For private repositories people with Read role can trigger builds HOT 1
- The plugin triggers builds for PRs with same number in different repositories HOT 4
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from github-pr-comment-build-plugin.