Comments (6)
bluesliverx
commented on July 20, 2024
@cw-pratik, sorry to take so long to get back to you. If I'm understanding right, it looks like you are expecting the automatic webhook creation to handle adding ISSUE_COMMENT and PULL_REQUEST_REVIEW_COMMENT to the hook request. This plugin implements the GHEventsSubscriber extension classes (PR review, PR updates, and issue comments), which should be included by the github-plugin's WebhookManager.
The logs seem to say that the correct events are registered in some cases and not in others, as well. Do you know why that is?
from github-pr-comment-build-plugin.
oleg-nenashev
commented on July 20, 2024
With https://www.jenkins.io/blog/2020/04/16/github-app-authentication/ it might be possible to update this plugin to work without additional magic once the instance is connected as a GitHub app. It will likely require some updates in the plugin. CC @timja
from github-pr-comment-build-plugin.
thorntonryan
commented on July 20, 2024
@cw-pratik , I ran into a similar issue when configuring the plugin.
My first obvious mistake, was forgetting to edit my Jenkins webhook to include comments:
- Issue comments
Issue comment created, edited, or deleted.
I'm guessing you weren't making this mistake. But it's helpful to double check.
The next thing that got me was my regex.
From the place you edit your webhook events, you can also see a list of "Recent Deliveries" containing the text of the JSON being sent to your Jenkins server.
Make sure your regex can handle the input it's getting.
From your screenshot, your regex appears to be Release-H *-*. Since there's no leading .*, you won't be able to issue any preceding newlines or other whitespace in your comment. Not sure if this was your intent, but it totally burned me :)
from github-pr-comment-build-plugin.
grEvenX
commented on July 20, 2024
@thorntonryan Had the same issue as you. I guess the problem is that the default GitHub multi branch plugin doesn't include "issue comments" when managing the web-hooks?
from github-pr-comment-build-plugin.
lprimak
commented on July 20, 2024
This may have been fixed by later versions of Jenkins
In fact, I just created another project and the issue comment field is set for the webhook.
Most likely this issue is fixed.
from github-pr-comment-build-plugin.
bluesliverx
commented on July 20, 2024
Please reopen if not.
from github-pr-comment-build-plugin.
Related Issues (20)
- Question - Github App Authentication - Does it work? HOT 2
- Job is triggered twice with this plugin HOT 3
- Better Support for Job DSL configuration of GitHub Organization Folder HOT 2
- The plugin is not triggered with a multibranch pipeline HOT 2
- This plugin triggers the build twice HOT 8
- not able to retrieve getCommentBody or getCommentURL from currentBuild.buildCauses HOT 11
- Unable to trigger build with wildcard in the comment body HOT 2
- Does the latest version support trigger building in multibranch pipeline project? HOT 3
- plugin doesn't trigger a build when a PR comment is issued HOT 2
- Restrict build trigger to project group members HOT 14
- Trigger more than one job with single PR comment HOT 1
- isAuthorized() throws an exception when it should return false
- Comment text as env-var to job HOT 1
- Please give some example pipeline code in the README
- Triggerring more than one job with single PR comment is broken HOT 6
- what is a "trusted" user as defined by this plugin HOT 16
- Thumbs up/down on successful/failed submission HOT 8
- Document the requirement for branch discovery behavior HOT 4
- For private repositories people with Read role can trigger builds HOT 1
- The plugin triggers builds for PRs with same number in different repositories HOT 4
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from github-pr-comment-build-plugin.