ether / ep_author_hover Goto Github PK

When hovering over a text part I get this error:

Could not find string ep_author_hover.unknow_author html10n.js:742:34
TypeError: authorName is undefined
anonymous/<["ep_author_hover/static/js/index.js"]/showAuthor.draw()
 require-kernel.js line 226 > Function:137
anonymous/<["ep_author_hover/static/js/index.js"]/showAuthor.show()
 require-kernel.js line 226 > Function:71
anonymous/<["ep_author_hover/static/js/index.js"]/showAuthor.hover/timer<()
 require-kernel.js line 226 > Function:59
 require-kernel.js line 226 > Function:137:5
Syntax-Fehler

Firefox 46.0.1
Etherpad 1.6

To replicate
create pad
Copy/Paste

Where can I read more about this?
http://beta.etherpad.org/p/sfc

This produces that on wide screens the tooltip is displayed far off from the cursor position and text

small video example https://covid19.framadrop.org/lufi/r/zs78RHhHG8#Q/q/gD5jmWwwu7tiGWrxNcHIXE5RLZvFfBruXu0tfG4=

pr #19 seems to fix the issue

I think the changes in 4569f63 are spamming my logfile.

[2015-04-06 11:01:22.687] [WARN] client - TypeError: $(...).closest(...).get(...) is undefined -- { errorId: 'UKFjC9yiVwmBQ91hw90b',
  msg: 'TypeError: $(...).closest(...).get(...) is undefined',
  url: 'REDACTED',
  linenumber: 65,
  userAgent: 'Mozilla/5.0 (Windows NT 6.2; WOW64; rv:36.0) Gecko/20100101 Firefox/36.0' }

Would be good if you had a way to disable the hover on existing text and a way to disable the hover all together.

The hover on existing text causes some readability problems and issues on phones. Maybe a way to address this would be to only show hover on text when the mouse has been hovering for a few seconds.

The ability to disable the hover altogether would be good to give the option to the end users.

Thanks

Issue Description:

For this author string "author-a-z76zuz70zz81zz67zz122zgoz122zz88zz83zz75zz89zz66zz67z5" specified in html span tag, static/js/index.js wrongly decodes it to "a.LuFQCzgozXSz75", whereas the real author id should be "a.LuFQCzgozXSKYBC5". This caused this plugin to show "Unknown Author" in our etherpad lite instance.

Suggested solution:

Comment out/remove line 74 of static/js/index.js, as substring(0,49) is causing trouble in our case:
//className = className.substring(0,49);
After commenting out this line, author info was correctly shown when clicking (hovering) color highlighted lines.

Environment:

Etherpad Lite: commit 08b90437c1fdcb62609f03c6b75a9dcb43865deb (2016-08-01)
OS: Linux dev-businesstime-4 3.2.0-4-amd64 #1 SMP Debian 3.2.41-2+deb7u2 x86_64 GNU/Linux
ep_author_hover installed by npm install: ├── [email protected]

https://www.npmjs.com/package/ep_authornames looks similar to this plugin. How do they relate/differ? The README for this plugin has a "Why did I rewrite this?" section. Is this plugin a rewrite of ep_authornames? Please document in the README.

System

OS: Windows as well as iOS and Linux
Browser: Firefox 76
Etherpad: Version 1.8.3

Problem Description

Hover shows directly and follows the mouse. With this, it always shadows text and distracts from writing and reading. We (10 users) really don't like the new functionality. The old functionality worked way better for us. Maybe the hover should show after 2 seconds, in the old version it maybe took a bit too long.

Possible solution

Restore old functionality with shorter delay or put the hover to the right side of the pad.

Hello,

is it possible to get, convert and show the timestamp of each author?
Could do it myself it I get some hint`s for the functions and code.

thanks
Birgit

Hi, thank you for this plugin, it is very useful to know at first glance who wrote a sentence.

It seems that label name is always in english, is it possible to put it in locale file to allow contributors to translate it?

In french, it would be translated into "Afficher l'auteur en surimpression".
Thank you. :)

Hi, after updating to etherpad 1.8.3 (and updating all plugins) i got this error Failed to load 'ep_author_hover/static/js/index' for 'ep_author_hover/ep_author_hover/client_hooks/postAceInit': Error: The module at "ep_author_hover/static/js/index" does not exist. which result in a state that the hover is never shown.

Usually I can't read the names because the hover appears over some other text.
Adding a background color to the div may helb to make the names readable.