Code Monkey home page Code Monkey logo

Comments (7)

JohnMcLear avatar JohnMcLear commented on July 25, 2024 1

Should be resolved now.

from ep_author_hover.

JohnMcLear avatar JohnMcLear commented on July 25, 2024

Browser, OS? STR?

from ep_author_hover.

amfl avatar amfl commented on July 25, 2024

Firefox 36.0.4, Win 8 client, Ubuntu 14.04 Server

  1. Set up etherpad tagged as 1.5.2 b9cdf4352b957b9127b6404af8b0078cb3309f0b
  2. Install ep_author_hover from /admin/plugins
  3. Load a pad, try to hover some things

from ep_author_hover.

amfl avatar amfl commented on July 25, 2024

I'm not certain on every situation where it happens, but it's at least definitely triggerable by hovering a blank area to the right of text.

Chrome exhibits the same behavior.

from ep_author_hover.

R1kk3r avatar R1kk3r commented on July 25, 2024

In index.js, the function "closest()" is used but you must check what is returned. Sometimes, on blank line, <span> entitie is not found. Fixed in my fork . I need a bit more work to handle all cases and also understand how to retrieve authornames correctly before doing a pull request.

from ep_author_hover.

JohnMcLear avatar JohnMcLear commented on July 25, 2024

Thanks @R1kk3r bump me when you have a full pull ready and I will get it merged :)

from ep_author_hover.

Cyrille37 avatar Cyrille37 commented on July 25, 2024

Hi.
I confirm the error with EP 1.5.7 and author_hover 0.0.8.
I think it (probally) comes from parts that were "cleaned" : they lost colors and author information.

[2015-09-28 23:07:36.198] [WARN] client - TypeError: $(...).closest(...).get(...) is undefined -- { errorId: 'TN1FtfTZE8iaGzI0cSjJ',
  msg: 'TypeError: $(...).closest(...).get(...) is undefined',
  url: 'http://pad.comptoir.net/p/xxxxxxxx',
  linenumber: 65,
  userAgent: 'Mozilla/5.0 (Windows NT 6.0; WOW64; rv:41.0) Gecko/20100101 Firefox/41.0' }

Cheers

from ep_author_hover.

Related Issues (12)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.