Comments (7)
Should be resolved now.
from ep_author_hover.
Browser, OS? STR?
from ep_author_hover.
Firefox 36.0.4, Win 8 client, Ubuntu 14.04 Server
- Set up etherpad tagged as 1.5.2 b9cdf4352b957b9127b6404af8b0078cb3309f0b
- Install ep_author_hover from /admin/plugins
- Load a pad, try to hover some things
from ep_author_hover.
I'm not certain on every situation where it happens, but it's at least definitely triggerable by hovering a blank area to the right of text.
Chrome exhibits the same behavior.
from ep_author_hover.
In index.js, the function "closest()" is used but you must check what is returned. Sometimes, on blank line, <span>
entitie is not found. Fixed in my fork . I need a bit more work to handle all cases and also understand how to retrieve authornames correctly before doing a pull request.
from ep_author_hover.
Thanks @R1kk3r bump me when you have a full pull ready and I will get it merged :)
from ep_author_hover.
Hi.
I confirm the error with EP 1.5.7 and author_hover 0.0.8.
I think it (probally) comes from parts that were "cleaned" : they lost colors and author information.
[2015-09-28 23:07:36.198] [WARN] client - TypeError: $(...).closest(...).get(...) is undefined -- { errorId: 'TN1FtfTZE8iaGzI0cSjJ',
msg: 'TypeError: $(...).closest(...).get(...) is undefined',
url: 'http://pad.comptoir.net/p/xxxxxxxx',
linenumber: 65,
userAgent: 'Mozilla/5.0 (Windows NT 6.0; WOW64; rv:41.0) Gecko/20100101 Firefox/41.0' }
Cheers
from ep_author_hover.
Related Issues (12)
- Hovering over link shows unknown author HOT 1
- authorId not properly decoded causing "Unknown Author"
- creation of locales to help to translate HOT 2
- error with etherpad 1.8.3 HOT 11
- [Question] Unusual behaviour with new version HOT 5
- Way to disabled hover on existing text HOT 3
- Author tooltip's position is is tied to the page window instead of the pad content HOT 2
- Please document how this plugin relates to ep_authornames HOT 1
- Add background color HOT 3
- Show date of change with author_hover HOT 1
- "Me" not shown on hover HOT 14
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from ep_author_hover.