error with etherpad 1.8.3 about ep_author_hover HOT 11 CLOSED

Try a clean remove/reinstall of the plugin.

I tested on 1.8.3 and it's working fine here and I put it on video.etherpad.com to double check and it seems fine there?

from ep_author_hover.

@JohnMcLear thx for the feedback, no error on video.etherpad.com but from my test the tooltip show "Me" for every author ever when i set their names (and it seems that name is not saved in cookies since it's reset on every page reload).

from ep_author_hover.

ah yeah I think that bug was due to ep_webrtc, I just updated it..

from ep_author_hover.

Nice, i don't get why it bug from our side, since i've removed all node_modules and resintalled fresh plugins after the upgrade, what do you mean by "a clean remove/reinstall of the plugin" ? A simple npm uninstall ?

from ep_author_hover.

I did npm install ep_webrtc then cleared browser cache and restarted Etherpad.

from ep_author_hover.

'k installed it again and still nothing good, this should come from this error generated by ep_adminpads Failed to load 'ep_adminpads/static/js/admin/pads:documentReady' for 'ep_adminpads/ep_adminpads/client_hooks/documentReady': Error: The module at "ep_adminpads/static/js/admin/pads" does not exist. ace2_common.js:36:445. Since admin_pads is broken, i've uninstalled this one, but author names are still not showed :\

Here is the instance on which i'm testing it https://lite2.infini.fr/p/bac-a-sable2

from ep_author_hover.

Do you see the problem on video.etherpad.com ?

from ep_author_hover.

No it works well, but... https://video.etherpad.com/pluginfw/plugin-definitions.json show me that you are using ep_authorname not ep_author_hover (which is related to this repo). I'll try to switch to ep_authorname which seems to do the job :p

from ep_author_hover.

lol doh :D Sorry too many plugins ;)

from ep_author_hover.

Leaving the issue open since the bug until you confirm it works for you :p

FTR there is another bug with ep_athornames see etinquis/etherpad-plugins#29 :s

from ep_author_hover.

Fixed :)

from ep_author_hover.