chronossc / django-breadcrumbs Goto Github PK

Django 1.2

To reproduce:

1. add 'django.contrib.flatpages' to INSTALLED_APPS
2. add 'breadcrumbs.middleware.BreadcrumbsMiddleware' and 'breadcrumbs.middleware.FlatpageFallbackMiddleware' to MIDDLEWARE_CLASSES
3. ./manage.py test flatpages

Result:
FAIL: test_fallback_flatpage (django.contrib.flatpages.tests.views.FlatpageViewTests)
A fallback flatpage won't be served if the middleware is disabled

Traceback (most recent call last):
  File "<redacted>/lib/python2.7/site-packages/django/contrib/flatpages/tests/views.py", line 48, in test_fallback_flatpage
    self.assertEquals(response.status_code, 404)
AssertionError: 200 != 404

Unit tests today is something that I, even, can't call ugly ...

Write descent unit tests and try to make it compatible with Django 1.2.x, 1.3.x, and 1.4.x

I notice Breadcrumbs is a singleton. Won't this give each user on the system the same breadcrumb trail? That is not desirable, is it?

Also, why does the middleware's process_request call the _clean method? Doesn't that dump all the existing crumbs, thereby leaving only the single crumb added by the view, thereby defeating the purpose of breadcrumbs?

Am I missing something about how this application is intended to be used?

Thanks,

--Stuart

Hi,

This repository seems to lack maintenance, I propose myself as a new maintainer.

Could you transfer it on my account in github or give me the right to push in your repository ?

Thank you

If you are using Django's flatpages app, the following will work with django-breadcrumbs:

urlpatterns = patterns('',
    url(r'^flatpage/childflatpage/childchildflatpage', include('django.contrib.flatpages.urls')),
    url(r'^flatpage/childflatpage/', include('django.contrib.flatpages.urls')),
    url(r'^flatpage/', include('django.contrib.flatpages.urls')),
)

This gets cumbersome if you have many flatpages. A common approach to handle this is to specify a catchall term as the last entry in urls.py:

# Your other patterns here
urlpatterns += patterns('django.contrib.flatpages.views',
    (r'^(?P<url>.*)$', 'flatpage'),
)

Implementing the latter scenario with django-breadcrumbs (at least under Django 1.4) results in no breadcrumbs being generated.

Is this intentional, a side-effect, or a bug? I am not entirely sure.

Hi

Can you update the wiki that the settings.py should also contain TEMPLATE_CONTEXT_PROCESSORS
especially the 'django.core.context_processors.request',

TEMPLATE_CONTEXT_PROCESSORS = (
"django.contrib.auth.context_processors.auth",
"django.core.context_processors.debug",
"django.core.context_processors.i18n",
"django.core.context_processors.media",
"django.contrib.messages.context_processors.messages",
'django.core.context_processors.request',
)

Thanks
Vemu

When upgrading my project to Django 1.10 and adopted the new MIDDLEWARE setting instead of the deprecated one (MIDDLEWARE_CLASSES), django-breadcrumbs crashes as its not compatible with this new Django 1.10 setting.

Are you planning to provide support for this?