Code Monkey home page Code Monkey logo

Comments (3)

chronossc avatar chronossc commented on July 17, 2024

I'll check that tonight. May you have some more info?

from django-breadcrumbs.

robnewman avatar robnewman commented on July 17, 2024

The problem alanwj documented still exists:

Creating test database for alias 'default'...
........................................F.....
======================================================================
FAIL: test_fallback_flatpage (django.contrib.flatpages.tests.views.FlatpageViewTests)
A fallback flatpage won't be served if the middleware is disabled
----------------------------------------------------------------------
Traceback (most recent call last):
  File "/path/to/django/contrib/flatpages/tests/views.py", line 55, in test_fallback_flatpage
    self.assertEqual(response.status_code, 404)
AssertionError: 200 != 404

----------------------------------------------------------------------
Ran 46 tests in 2.933s

FAILED (failures=1)
Destroying test database for alias 'default'...

from django-breadcrumbs.

chronossc avatar chronossc commented on July 17, 2024

I checked that again, with more accuracy.

The flatpages test remove flatpage middleware from settings.MIDDLEWARE_CLASSES to test it.

Unfortunately Django don't know about breadcrumbs FlatpageFallbackMiddleware, so it never can test to it (something in settings here can help, but isn't case).

In commit d8a8b92 I do a check in middleware to return response if flatpages middleware isn't in MIDDLEWARE_CLASSES, but now I realized that if I do it, it will be true always, and it isn't acceptable :).

So, while Django not offer a way to configure replacement middlewares for FlatPages, and test based on that, this issue will be closed as Wont Fix.

from django-breadcrumbs.

Related Issues (8)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.