Comments (5)
Hello Stuart.
I will make tests trying to reproduce points that you wrote at this issue.
I will not reply all questions here because I wrote breadcrumbs have many years and don't remember everything about code now, but about singleton, as I remember, I used a singleton with idea of have one breadcrumbs instance over all request, and never experienced 'cross breadcrumbs', but now sounds weird and I will take a better look :).
Thx!
from django-breadcrumbs.
Hello Felipe --
Thanks for the quick reply! I appreciate that you made this project available on github, and I noticed that it has been a while since you made changes to it. So don't worry too much about it. Mainly I just wanted to make sure I wasn't missing something obvious on my end.
Cheers!
--Stuart
from django-breadcrumbs.
I came here investigating this same issue. I've seen behavior that I'm pretty sure is tied to the use of Singleton, although it's hard to reproduce. We are running Django via Apache/wsgi, and if multiple users are making requests at the same time, one of them may get nothing while the other gets a concatenation of both sets of breadcrumbs.
I noticed there is a fork at https://github.com/alepane21/django-breadcrumbs which appears to do nothing but remove the Singleton behavior -- I don't know the author or how it's been tested, but it seems like a simple enough change.
from django-breadcrumbs.
Wil check that this weekend.
Someone have a idea how I can reproduce this kind of test in a unit or
integration test?
Felipe 'chronos' Prenholato.
Linux User nº 405489
Home page: http://devwithpassion.com | http://chronosbox.org/blog
GitHub: http://github.com/chronossc/ | Twitter: http://twitter.com/chronossc
2014-06-17 20:39 GMT-03:00 adam-iris [email protected]:
I came here investigating this same issue. I've seen behavior that I'm
pretty sure is tied to the use of Singleton, although it's hard to
reproduce. We are running Django via Apache/wsgi, and if multiple users are
making requests at the same time, one of them may get nothing while the
other gets a concatenation of both sets of breadcrumbs.I noticed there is a fork at
https://github.com/alepane21/django-breadcrumbs which appears to do
nothing but remove the Singleton behavior -- I don't know the author or how
it's been tested, but it seems like a simple enough change.—
Reply to this email directly or view it on GitHub
#12 (comment)
.
from django-breadcrumbs.
This issue makes this library impossible to use with django's CachedTemplateLoader:
https://docs.djangoproject.com/en/1.8/ref/templates/api/#django.template.loaders.cached.Loader
All of the built-in Django template tags are safe to use with the cached loader, but if you’re using custom template tags that come from third party packages, or that you wrote yourself, you should ensure that the Node implementation for each tag is thread-safe. For more information, see template tag thread safety considerations.
from django-breadcrumbs.
Related Issues (8)
- Add a small note on the context_processor HOT 1
- This project needs a maintainer HOT 1
- Unit tests in the django flatpage's app fail when breadcrumbs FlatpageFallbackMiddleware is enabled. HOT 3
- Django 1.10 support? HOT 5
- Update pypi package HOT 5
- Breadcrumbs don't resolve when using the 'catchall' url pattern in urls.py for flatpages HOT 6
- Write unit tests
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from django-breadcrumbs.