Handlers, components etc.

Database and NetworkHandlers will need to be updated.

Some of the saga tests are irrelevant for the service that they are testing. ie. without a response from the API. Does that ever happen? Is it even necessary to test that case?

Serves as self-documentation, ie.

network: null

is far less descriptive than

network: {
  type: null,
  effectiveType: null
}

https://rnfirebase.io/docs/master/notifications/introduction

Messaging is now only handling data-only notifications. We need both notifications and data-only notifications.

They are bad-ass.

This:

import RemoteImage from '../../../components/RemoteImage';

Changes to this:

import RemoteImage from 'components/RemoteImage';

How lovely.

https://github.com/tleunen/babel-plugin-module-resolver

https://medium.com/@davidjwoody/how-to-use-absolute-paths-in-react-native-6b06ae3f65d1

Apparently a performance improvement since it's native.

Detox seems to be the most mature, easier to use library out there right now.

This will decouple the error logic.

Will need to create an ErrorHandler and remove that logic from SystemMessageHandler.

ie. Currently we have

Example
  index.js
  Example.js

which is unnecessary and should be corrected to:

Example
  index.js

The same concept should be applied to utils to make tests more explicit.

Causing iOS build error with Firestore.

invertase/react-native-firebase#758

Null value causing crash

Character restriction shows blank value / TOTAL.

Not sure if it's being maintained.

Consider finding a replacement, forking or waiting for fork.

• Does not display close button
• Disables back android

Navigating the docs is tedious. Add TOCs.

See sync saga.

Utils.createError should be utils.app.createError.

Missing Slack webhook url should not call post.

Write tests for the utils and anything else that is testable.

E.g. moveFile, deleteFile.

At the moment we have a mix between the above and object imports. Let's stick to the above for consistency.

Would really appreciate some help mocking react-native-firebase.

https://stackoverflow.com/questions/50853124/how-to-mock-stub-react-native-firebase

Also, add functionality to disable error logging to the db.

I have not been able to write tests for the following services (due to a lack of expertise on my part):

• getDeviceLocation
• resizeImage
• showImagePicker
• UploadFile
• All database services
• Sync saga, specifically testing that the eventChannel works

Looking for help here.

A few unneeded files (travis.yml etc) were not removed.

Has new destructuring required prop.

Deployment should include firebase env.

Also, the headings aren't formatted consistently.

https://github.com/afitiskin/redux-saga-routines

We are currently dispatching actions directly from sagas and not using action creators. This library abstracts that boilerplate away and you end up with 5 actions for each phase of an async action, ie. trigger, request, success, failure, fulfill. This approach is considered best practice and it is definitely an improvement to our current setup.

functionName = () => {} 

is now moving to the stable ES5 way of binding class methods

functionName() {}

because testing is easier, it is more performant and it is self documenting.

Article
React issue

Once unit testing is incorporated, it would be great to have these tests run on PR's and builds automatically deployed to beta on merge into master.

Will save about 3 hours of setup.

It's done really well here.

Create a helpers file that links to styleConstants to do this.

Remove current environment settings for the db when this is done.

ADD_PENDING_TRANSACTION
REMOVE_PENDING_TRANSACTION

Use Sentry (or flavour of or custom server) and some redux Middleware.