adobe / commerce-events Goto Github PK
View Code? Open in Web Editor NEWLicense: MIT License
License: MIT License
orderId is typed as a number:
but there are all kinds of valid usecases of orderId as string; here is just one example from the community:
https://magentocommeng.slack.com/archives/C02321ZPXPY/p1680082113087649
Can follow links in https://github.com/adobe/commerce-events/blob/main/packages/storefront-events-sdk/README.md to examples and schemas.
Links have commerce-events-sdk
in the path instead of storefront-events-sdk
and lead to a 404.
Example: https://github.com/adobe/commerce-events/blob/main/packages/commerce-events-sdk/src/types/schemas/shoppingCart.ts instead of https://github.com/adobe/commerce-events/blob/main/packages/storefront-events-sdk/src/types/schemas/shoppingCart.ts
I have experienced that recommendation items sometimes are returned by Adobe Sensei without price information.
The response from https://commerce.adobe.io/recs/v1/precs/preconfigured should return a price section such as,
"prices": {
"maximum": {
"finalAdjustments": [],
"regular": 699.0,
"regularAdjustments": [],
"final": 699.0
},
"minimum": {
"finalAdjustments": [],
"regular": 699.0,
"regularAdjustments": [],
"final": 699.0
}
},
But for some products I get the following in the response,
"prices": {},
This creates problems for the recommendedItem context and it will return a type error. The crash (type error) occurs in the following code section.
I think that it would be helpful to improve error handling, not sure exactly what can be done since the problem seems to be on the server side. I suggest that such "broken" items without price are filtered out by the recommended item context to avoid the entire app to crash when such item is recommended.
@ryanhissey hyva is having issues setting shopping cart context with subtotalIncludingTax
and subtotalExcludingTax
(non-required fields) missing. it's causing conversion tracking issues with hyva as all events that require a shopping cart context are sent to the bad bucket in sp
A declarative, efficient, and flexible JavaScript library for building user interfaces.
๐ Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
An Open Source Machine Learning Framework for Everyone
The Web framework for perfectionists with deadlines.
A PHP framework for web artisans
Bring data to life with SVG, Canvas and HTML. ๐๐๐
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
Some thing interesting about web. New door for the world.
A server is a program made to process requests and deliver data to clients.
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
Some thing interesting about visualization, use data art
Some thing interesting about game, make everyone happy.
We are working to build community through open source technology. NB: members must have two-factor auth.
Open source projects and samples from Microsoft.
Google โค๏ธ Open Source for everyone.
Alibaba Open Source for everyone
Data-Driven Documents codes.
China tencent open source team.