Code Monkey home page Code Monkey logo

commerce-events's Introduction

Adobe Commerce Events

A monorepo for Adobe Commerce Events packages. This repo is using turborepo to manage packages.

Getting Started

This turborepo uses Yarn as a package manager. Install yarn if you haven't already by running npm install -g yarn.

Develop

To develop all apps and packages, run the following command:

cd commerce-events
yarn dev

This runs all packages and examples at the same time. The newer examples are using NextJS to make sure we cover use cases for modern package development. Under the old-examples, we are using parcel to just quickly host static files and test our amd/umd scripts.

Under the dev script, our built files are hosted at:

  • sdk - http://localhost:8080/index.js
  • collector - http://localhost:8081/index.js

Release process

QA

Merging a change to the main branch triggers a github action that builds and deploys the latest code to QA: https://unpkg.com/@adobe/magento-storefront-event-collector@qa/dist/index.js.

Production

Release steps:

  • create a PR with a version bump in the package.json and package-lock.json in the package(s) you're releasing (example PR here)

  • once the PR is approved and merged, create a new release tag for the repo

Creating a new release tag triggers a github action that builds and deploys the latest code to Prod: https://unpkg.com/@adobe/magento-storefront-event-collector/dist/index.js.

NPM Packages

Name NPM Namespace version
storefront-events-sdk @adobe/magento-storefront-events-sdk 1.x
storefront-events-collector @adobe/magento-storefront-event-collector 1.x

commerce-events's People

Contributors

aniham avatar bbatsche avatar benjaminkalk avatar grahamcrackers avatar jasonrpoteet avatar michaelyu0123 avatar nadiyas avatar

Stargazers

 avatar  avatar  avatar

Watchers

 avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar

commerce-events's Issues

failed snowplow validation on non-required fields

@ryanhissey hyva is having issues setting shopping cart context with subtotalIncludingTax and subtotalExcludingTax (non-required fields) missing. it's causing conversion tracking issues with hyva as all events that require a shopping cart context are sent to the bad bucket in sp

Links in storefront-events-sdk README are broken

Problem with items without price

I have experienced that recommendation items sometimes are returned by Adobe Sensei without price information.

The response from https://commerce.adobe.io/recs/v1/precs/preconfigured should return a price section such as,

"prices": {
                        "maximum": {
                            "finalAdjustments": [],
                            "regular": 699.0,
                            "regularAdjustments": [],
                            "final": 699.0
                        },
                        "minimum": {
                            "finalAdjustments": [],
                            "regular": 699.0,
                            "regularAdjustments": [],
                            "final": 699.0
                        }
                    },

But for some products I get the following in the response,

"prices": {},

This creates problems for the recommendedItem context and it will return a type error. The crash (type error) occurs in the following code section.

I think that it would be helpful to improve error handling, not sure exactly what can be done since the problem seems to be on the server side. I suggest that such "broken" items without price are filtered out by the recommended item context to avoid the entire app to crash when such item is recommended.

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    ๐Ÿ–– Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. ๐Ÿ“Š๐Ÿ“ˆ๐ŸŽ‰

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google โค๏ธ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.