orderId is typed as a number: <a href="https://github.com/adobe/comm

Alternative suggestion for solving this issue: <div class="snippet-clipboard-conte

<a class="user-mention notranslate" data-hovercard-type="user" data-hovercard-url="/us

orderId type in SDK schema is `number`, should be `sting` about commerce-events HOT 2 CLOSED

aniham commented on July 23, 2024 2

orderId type in SDK schema is `number`, should be `sting`

from commerce-events.

Comments (2)

hannes011 commented on July 23, 2024

Alternative suggestion for solving this issue:

diff --git a/ViewModel/Checkout/SuccessContextProvider.php b/ViewModel/Checkout/SuccessContextProvider.php
index 4a1dce9..64865e0 100644
--- a/ViewModel/Checkout/SuccessContextProvider.php
+++ b/ViewModel/Checkout/SuccessContextProvider.php
@@ -61,11 +61,11 @@ class SuccessContextProvider implements ArgumentInterface
     /**
      * Return order id for event tracking
      *
-     * @return string
+     * @return int
      */
-    public function getOrderId() : string
+    public function getOrderId() : int
     {
-        return $this->checkoutSession->getLastRealOrder()->getIncrementId();
+        return (int)$this->checkoutSession->getLastRealOrder()->getEntityId();
     }
 
     /**

OR - as you suggested: changing the type in the event library + adjusting template view/frontend/templates/checkout-success.phtml to prevent having a JS error on the checkout success page: