yingqichao / robust-perceptual-image-hashing-based-on-ring-partition-and-nmf Goto Github PK

see at ~ line 550ff:
`

		for (int i = 0; i < len; i++) {
			V.at<float>(row, r + 1) = vectorHolder[r][i];
			row++;
		}

using r+1 skips index 0 but accesses index at size() . I think it should be V.at(row, r) = vectorHolder[r][i];

in SingleHashCode:

map<string, uchar*> m1;
m1.insert(make_pair(in, f1));
delete []f1;

f1 is deleted but later used via the map. Anyway, the code could be simplified a lot here, the map size is always 1