yeg-relief / youcanbenefit Goto Github PK

We probably don't need to convince the front end we're querying it from the same domain.

• Use question label instead of key in program queries
• Remove Keys section
• Replace input type "type" with Number Input or something similar
• Infer key type from question input type
• Add input type to nested multiselect questions

This issue will break the City of Edmonton's current YCB schema. We will need to write a script to transform it to the new keyless schema.

Currently the search option is set to "search disabled" by default. Also, when the "search title" option is selected, no programs are listed initially. We would want it to list all the programs by default and then the user can enter in text as a filter.

Requested by Katie Walker.

We need to upgrade our deps again.

Front end:

found 4 vulnerabilities (2 low, 2 high) in 40290 scanned packages
  run `npm audit fix` to fix 3 of them.
  1 vulnerability requires semver-major dependency updates.

Back end:

found 385 vulnerabilities (226 low, 146 moderate, 13 high) in 11829 scanned packages
  385 vulnerabilities require semver-major dependency updates.

The main wiki is here. We also have some important readme files here, here, and here.

Katie has requested to put the following under the "Eligibility Screener" title and before the questions:

“You Can Benefit can be used to find out what benefits you are eligible for right now. It can also be used to plan ahead by finding out what benefits you might be able to get in the future if your life changes. Feel free to submit this questionnaire as many times as you like to explore different possibilities.”

We could either put this in manually or make it customizable so that an admin user can create it if he or she wants to and edit it as desired.

We've gone back and forth on this, but we should colocate Dockerfiles with the source, while removing any Kubespec files. We will be migrating to using Helm to manage YCB soon, so it will be stored in a City-run private repository.

There is a critical issue in event-stream. See here.

Keys only support integer and boolean types.

Also rename "number" to "integer" for consistency throughout the program

We currently have problems with reproducibility. Our snapshots often change:

      Object {
        "guid": "hp5mupqcVY8ZMiKg7Q91Uoi4Wf",
        "queryIDs": Array [
    -     "C8NZoL1Nf7VEgEC4VMFI9GlebN",
          "d5NswIlUvzxY0AJ1hGm4eKQtS4",
    +     "fMwdx1jiAZUt09ALDer98GardT",
          "JeXk8cOZnqJMepmHpxDqpsEXNE",
          "jI1HlTlpbULsSVUmHnYi3ZlVJ7",
          "jzMQkEK41gnhmwWyxAuWF3eZ4d",
          "NOyR66aE30dJYXgdHJ2CvGLpnx",
          "qZyokzKnpIw3Ue6mdTi8je3knK",

We need our snapshots to be the exact same between runs.

We mostly just want to recognize @slmyers .

At the screen to edit the details of a program, there is a delete program button in the top right corner. No network request is sent when this is clicked and a snackbar always responds with "delete failure."

Deleting a program from the list of programs (program-overview) still works.

When I delete a query, then refresh the page, the query I thought I deleted is still there.

Fix should be same as #36

Some questions can confuse people. One of the questions on the City of Edmonton You Can Benefit site is "What is your Household's Total or Gross yearly income? (check line 150 of your tax return) Option: If you don't know your gross income, multiply your monthly income by 12." Having a tooltip that can be hovered over to give more info would be helpful for citizens. In this case, maybe it could explain what your tax return looks like, where to find your income, etc.

DELETE http://localhost:3000/protected/query/77Oyiqj9BcS7eqnfvFa5r0XRWO
for any string after protected/query/ always responds with

{
    "found": true,
    "deleted": true
}

When a new query is created and the save button is clicked for the first time, an error pops up at the bottom saying "error: query not saved." Despite this error message, the query was actually saved.

updating the following

• Angular
• Material
• ngrx
• rxjs

This message often doesn't show up when the page loads quickly. I'm thinking we should just remove the 28 and have the message say, "Please wait a few seconds while we load data from government and nonprofit programs for you."

This will make keys easier to read. (ie. childdisability could become childDisability)

When I try to add a new query to a program, it gives an error.

Once a key is made, there is no way to delete it.

Could be an intentional design decision. Look into Elasticsearch.

Since keys have been replaced with question texts and some question texts are long, it is difficult to distinguish between one condition and the next. The type column can be removed since the type can be inferred from the question.

Creating new keys was erroneously removed from the app. It should be replaced.

Add KeyEditComponent <app-key-edit></app-key-edit> into the keys overview component

this area may give trouble. In that case, adapt so that you feed keys from here and delete troublesome code.

Also, this feature is needed because the site admins are thinking about adding new programs soon.

When editing multiselect screener questions, the button only ever shows "Add". It should change to "Save", as that would be clearer.

DELETE http://localhost:3000/protected/program/fpnaSzYV38Y87YEhfxTBaU9Eyv
for any string after protected/program/ always responds with

[
    {
        "deleted": true
    },
    {
        "took": 6,
        "timed_out": false,
        "total": 0,
        "deleted": 0,
        "batches": 0,
        "version_conflicts": 0,
        "noops": 0,
        "retries": {
            "bulk": 0,
            "search": 0
        },
        "throttled_millis": 0,
        "requests_per_second": -1,
        "throttled_until_millis": 0,
        "failures": []
    }
]

Currently, it's difficult to tell what keys where created for. If we could add a description, that would make things easier to understand.

It's easy to pass configuration to the backend through Docker. This makes configuring and creating new containers easy. It's a bit trickier in frontend apps. See here for some discussion on how to do it.

use case:

Is there a way to input an income query result as a range? I am working with the new Leisure Access Program and for people over the base amount but under another amount they will be eligible the Leisure Access Pass Lite. I would like to set it up so that for people eligible for the regular LAP they won’t see the Lite version (less confusing that way) but can’t seem to figure out how to set a minimum AND maximum income amount.

requires:

1. Making a new condition type in Query object.
2. Building UI to support constructing such a condition.
3. testing the feature.

When a user creates a program, adds some queries, but then clicks away from the page so that the program was never saved, the queries remain in elasticsearch. When queries are created on an existing program and the program is not saved, the queries remain (which I think we would want to have).

This bug isn't too big of a problem as it won't affect programs that show up since the programs for the queries don't exist.

use cases

Any way to copy a query set from one program to another? It would really speed up data entry if we could do this and then only have to modify one variable on the various queries rather than renter everything from scratch.

Is there a way to set it up so a single question makes someone ineligible for a program? For example I am working on the Alberta Adult Health Benefit and want to set it up so that if someone is on AISH then the program doesn’t show up regardless of their other answers. So far I think the only way to do that is to add aish to every query, is that correct?

requires

• Defining a Template object common to client, server and db.
• Implement Template endpoint on server.
• create programs/Template/*, where * := new | edit/:id
• Interface Template with Program.

It would be handy if we could have a little testing area where we assign keys values directly, and the queries are dynamically evaluated. It would display whether someone with the set keys would qualify for the program. As you edit your current query, it would dynamically adjust to tell you whether you qualify or not.

Building queries is the most arduous part of a YCB site administrator's role. If we could duplicate them, it would make it much easier.

We should be able to run our tests suite from anywhere. Currently, if you were to run integration.runner.sh from the backend folder rather than backend/tests, it would fail.

The page here will need to be customizable. GitHub's wiki pages allow a sidebar built from markdown, as well as a primary markdown area. Something similar could be integrated into YCB.

This probably only needs to be a single page, which should make it easier.

Compiling the frontend gives a few circular dependency warnings

When creating a new program, the program details and program queries may correspond to different guids. If you click create a new program, enter the program details and click save program, then you must navigate to a different route and then back to /admin/programs to see the new program and begin editing the queries. If you don't do this and instead click edit queries while in the program-edit view, the queries will be linked to a new program with a different guid.

However, if you click create new program and go to the edit queries view and then back to the edit details view, this is not a problem.

Also, we would want the request GET /protected/program to be sent every time the PROGRAMS tab is clicked so that new programs are listed after creating new programs. Right now it does not get sent when you go from /admin/programs/application-edit/:guid or /admin/programs/edit/:guid to /admin/programs/overview.

Katie wants some information on the about page and the documents and resources page to be updated. The child and family benefits calculator link is broken and should be updated. A link to a CPP calculator should be added. A disclaimer should be added on the about page. And a statement on the screener page should be added.

need a nice 404.html. We have one, but Caddyserver doesn't seem to want to show it.

The qualifiers on the query display are showing '<' in place of any qualifier (<, <=, =, =>, >).

This was a previous issue that had been solved.
Issue: yeg-relief/issue-tracker#26
PR: yeg-relief/api-server#21

The solution is to put a size parameter for searching elasticsearch (size: ids.length) on the mGetById() function of db.elasticsearch/client.service.ts.
For some reason our current code does not have this anymore.

We need simple bash scripts to build our custom Docker images.