xris1658 / musec-legacy Goto Github PK

Kontakt 7 is a sampler from Native Instruments.

Repoduce

• Load Kontakt 7 on a instrument track
• Delete the plugin

Error message

Exception 0xc0000005 encountered at address 0x00007ffb6fa40979: Access violation reading location 0x00000000

Stack trace

Seems like the event loop of the plugin window is still running after the plugin has been unloaded.

More details

• I encountered this issue with the Player version. I actually don't have the full version, but I'm pretty sure the issue will be present.
• I tested another NI plugin called Raum, which didn't make the application crash while unloading.

Only the right channel will be heard when using FlexASIO. The content of the left channel are successfully written in the left channel, but they are absent in the playback.

When Musec uses other drivers (e.g. ASIO4ALL), the playback has no problem; when FlexASIO is used by other DAWs, the playback has no problem either. So the problem might comes from Musec::Audio::Driver::onASIOBufferSwitchTimeInfo with case ASIOSTFloat32LSB, which is used by FlexASIO.

If the user has load a FabFilter plugin (either the VST2 version or VST3), then replacing this plugin with any other ones will crash the program. The return code is 0xc0000409, which leads to ERROR_STACK_BUFFER_OVERRUN.

The following articles might be useful:

• STATUS_STACK_BUFFER_OVERRUN doesn’t mean that there was a stack buffer overrun - The Old New Thing
• STATUS_BUFFER_OVERFLOW really should be named STATUS_BUFFER_OVERFLOW_PREVENTED - The Old New Thing

CLAP is a new plugin format. Check out free-audio/clap for details.

Problems I encountered or noticed

• While scanning plugins, the application will access invalid memory while destructing CLAPPlugin::eventInputList_, leading the program to crash.
• If EventList from clap-helpers is used for plugin process, then the process callback will make EventList access invalid memory, causing the program to crash. Currently CLAPPlugin::process won't call the process callback of the plugin (i.e. the CLAP plugins are "bypassed").

Hi there, 1st of all thanks for your awesome (voluntary) work !

Since we've doxed this git in our HyMPS project (under the DAW section), can you please fix licensing terms for it ?

Our "problem" is that does not generates a correct badge:

(generate url: https://flat.badgen.net/github/license/xris1658/musec/?label=LICENSE)

This could easily be fixed by choosing a "correct" license file through the GH's wizard.

Although it may sounds like a minor aspect, this could help other devs to understand how reuse your code in other open projects and vice-versa.

Last but not least, let us know how (in your opinion) we could improve our categorizations and links to resources in order to favor collaboration (and therefore evolution) between developers of listed projects.

Thanks in advance.

nih-plug is a set of plugins written in Rust. It's available in VST3 and CLAP.

Problems I encountered or noticed

• Parameters cannot be adjusted via the user interface.
• If I delete the plugin from the mixer, then the program will execute invalid memory after the plugin is unloaded, causing the program to crash.
  • The program might used dangling pointer of the window and its message processing function, because
    • Only Crisp and Diopser in nih-plug raise the issue, and only these plugins have the user interface.
    • QEventDispatcherWin32::processEvents(QFlags<…>) qeventdispatcher_win.cpp:607 is found in the call stack. This line calls DispatchMessage(const MSG*) of Windows API.
  • If I directly close the program without deleting the plugin first, the program will exit with no problem.

I'm pretty sure the problems are caused by the host instead of the plugin. I used MultitrackStudio Lite to use these plugins, and they worked with no problems I mentioned above.

The executable built with CMake misses UI components written with QML. So it can't boot. The executable built with qmake is fine though.

If this problem is fixed, then the build guide will be much easier.