xnul / drop Goto Github PK

The skipping happens periodically, causes skipping of anywhere from milliseconds of audio to multiple seconds. The varying nature of the bug suggests a mechanic that can be variable is at fault such as the buffering of the queueable audio sources. I suspect Drop isn't buffering the audio properly.

Because of commit 93eec1a, there is now a bug where music temporarily stops due to the above reasons. In order to fix, audio would have to be moved to a separate thread, but even then it doesn't account for the visual stall.

Need to research and adjust accordingly. I haven't compared them in awhile, so the bug might not exist anymore or matter.

When updating the configuration, some compatible boolean settings to don't seem to pass to the updated config file.

Maybe a keybind or button in the top right/left.

The icon is optimized for Windows and not Mac where the icon is significantly larger.

I'm using ffi to generate a dynamically allocated array of float values called waveform and for some reason if I stop writing to it, nil and extremely small values start creeping in. Here's the array at 35 seconds:

When a nil value creeps in, the loop in spectrum.draw() tries to iterate over it and fails to perform mathematical operations, resulting in an error message and the crash of Drop.

Example:

To reproduce, start Drop, load some music, pause, and wait a minute or so for a nil value to creep in.

Making the volume go down when 0 or up when 1, causes an error.

Using love.filedropped and love.directorydropped.

The current Icon is simply some vertical green lines and while that's fine, I wish to add some shadow, properly space the ticks, make each half identical, and smooth out the curves a bit more, if possible.

Thanks to commit 4f74d1e, an unintended, interesting mechanic arose where you can drag the scrubhead as far right as possible and it will actually switch songs. If you mess around with this a little, it stops the visualizer from playing the song.

Need to figure out why this mechanic happens and fix the bugs surrounding it.

Potentially add hooks, API, external folder, functions for typical effects/visualizations.

This is low-priority and will only be done once all of the possible performance improvements have been implemented and the code refactored.

Remember to implement calls for Bass, Midrange, Highrange sounds.

Originally, when pressing a key after starting Drop, it would attempt to load the songs found in appdata. If it didn't find any, it would stop and display a new message indicating there were no songs.

For some reason, it's now crashing for me.

At the moment when scaling the window really small the spectrum gets kind of hard to see. Implement a nonlinear scaling where as the window becomes smaller, the contents of the window scales smaller at a decreasing rate. The result would make the spectrum bigger than currently when in a smaller window, making that size more appealing for regular use.

This has to do with how hitboxes are checked and the fact the scrubhead go over the scrubbar's edge.

Only implement once the GUI has been decided on.

Because of commit 93eec1a, the comma and period key functionality has broken.

Love2D uses SDL and SDL doesn't seem to support this, but FPS increases significantly when behind windows on macOS.

Due to commit 93eec1a, the spectrum stopped changing when the scrub head was dragged. I think it was a nice effect, so I want to implement it again.

Window background detection is done by monitoring the refresh rate. It is optimized for 60hz by default, so higher refresh rates cause it to glitch and disable the spectrum. Can be changed manually, but should be added to the settings panel once implemented.

In the next commit a refresh rate variable will be located in love.load for a workaround. Just locate the variable and change the default value to your monitor's refresh rate.

Update: this variable is called monitor_refresh_rate and you can find it at the top of main.lua.

When resizing the audio queue for the recording device, there's an nil error when trying to queue sounddata.

Error: audio.lua:723: bad argument #1 to 'queue' (SoundData or lightuserdata expected, got nil)
stack traceback:
        [string "boot.lua"]:637: in function <[string "boot.lua"]:633>
        [C]: in function 'queue'
        audio.lua:723: in function 'resizeQueue'
        visualization.lua:281: in function 'setSamplingSize'
        visualizers/novis/novis.lua:4: in function 'catch_nil'
        visualization.lua:226: in function 'callback'
        visualization.lua:259: in function 'next'
        main.lua:211: in function 'catch_nil'
        main.lua:516: in function <main.lua:465>
        [string "boot.lua"]:503: in function <[string "boot.lua"]:493>
        [C]: in function 'xpcall'

Using this implements FFmpeg in Love2D, enabling support for many more audio formats. Usage:

Once you have started playing a song by dropping a folder or playing from the appdata folder, if you drop another music folder, the title of the current song will change.

Since there isn't a way to know when audio samples are processed, timestamps are currently calculated when audio samples are queued. When the end of the song is reached by the queuing system, there aren't anymore audio samples to queue, so it stops queuing which means the timestamps stop updating.

There are a couple solutions to this, but they aren't very solid. They would break easily and it would be a pain to implement. Additionally, this bug is so small it's impossible to notice, but if a dynamic queue size is implemented or the queue size is increased in the future, it could become noticeable.

As the title states.

When session_persistence is enabled and someone exits the program while in fullscreen mode, their window's screen position is not restored upon the next time launching the program. Instead, when you launch the program, you're in fullscreen, you exit and it puts the window at the center of the screen no matter what.

Reference..

There are ways to work around this, just none of them are clean.

Right now the code is super efficient, but very much spaghetti. I'll make it just slightly less efficient to simplify the code, increase its readability, and maintainability.

When going from windowed to fullscreen mode, the change is instant, but when going back to windowed mode from fullscreen, there is a delay of around 1.5 seconds. For a video player-esque application that switches between windowed and fullscreen fairly often, this is noticeable and significant lag that should be reduced/expunged.

FFT generation accounts for the majority of the visualizer's CPU usage. Drop currently uses a FFT library made in Lua, but if we use LuaJIT's FFI functionality, we may be able to use an FFT library made in C, greatly reducing CPU usage.

To implement this mechanic properly, I want to study FFTs further and then create a library specifically for handling this FFT-FFI integration.

It rarely ever happens, but after extended periods of time, Drop will quit seemingly at random. No error message is ever displayed, it just immediately exits.

Can't find a link yet, but since there is no error message, it is probably a bug with Love2D itself. It may have to do with decoders/queueable audio sources or obtaining audio samples.

Drop currently has a very basic overlay to control audio playback, but nothing else and with the upcoming Settings Panel in #14 improvements need to be made.

Could have two options. Remove one song in particular or all of them. Could be a keypress. Wouldn't fit in with the current UI plan though and would take up valuable space on the screen. Might not be worth.

If a playlist UI was implemented then it would definitely be worth it and extremely useful.

As this project has grown, I have found a lot of areas where a settings panel would be useful. For the time being editing the script should be fine, but eventually I wish to add a settings panel to the visualizer to ease that process. Before this happens, a design style needs to be determined and the GUI implemented (if it's decided there will be one).

Ideas:

• sample input size settings: 256, 512, 1024, 2048, custom
• tick distance slider (inside settings menu for default vis)
• screen ratio setting: 16/10, 16/9, 4/3
• fade options: toggle, turn off bloom, intensity slider (right side for louder
  songs, left for softer), auto
• more color options
• set fps cap. 0 = no cap. Works on Windows?
• switch visualization (maybe visualization-specific settings)
• window size persistence through program shutdowns

The fading mechanic is kind of neat, but can make the visualizer a little bit harder to look at. I wish to add a toggle when I implement the settings panel with this feature turned off by default.

Ideas:

• add fade bloom: this way the spectrum itself doesn't have to fade and the mechanic can still be shown off
• add fade transition softening: when a song goes from quiet to loud or the opposite, the fade transition can seem abrupt and a bit annoying

Hi, my name is Zuur W. I'm a graphic designer and I'd like to collaborate on your open source project and propose free logo/icon design for your project. If it's something you're interested in, please, let me know!
Best Regards
Zuur

Recently audio input support was added to Love2D. Add the ability to visualize that input. This could allow Drop to use system audio to generate visualizations, making it a lot more useful/cool.

Currently Drop simply displays the file name of the song. By default it should attempt to obtain standard audio metadata and then detail the song using that. If not, the file name can be used instead.

Now that Love is adding compression functions, it may be efficient to just save visualization data to the disk after going through the fft. That way, the fft only needs to be run once on each song. The resulting file storage may not be worth it though. It all depends on the compression algorithms.

Somehow the visualizer turns black if you try to disable fade. Can be fixed by going back to the menu afterwards and then playing songs again.