Code Monkey home page Code Monkey logo

wanikani-for-android's Introduction


End of Life

This project has reached EOL status. It will no longer be updated, patched, or supported. If you are interested in continuing the work, feel free to do so and republish the app anywhere, with respect to the license. Not sure why you would do that though, as this codebase is somewhat of a time machine and as such, in huge technical debt. It also doesn't integrate the new WaniKani API (v2).

Thank you all for the support throughout the life of this effort.

UPDATE: Revived by Michael Rothberg (Google Play, GitHub).


WaniKani for Android

A beautiful (unofficial) client app for the awesome kanji learning website wanikani.com

License

Copyright (C) 2013 İhsan Işık

This program is free software: you can redistribute it and/or modify
it under the terms of the GNU General Public License as published by
the Free Software Foundation, either version 3 of the License, or
(at your option) any later version.

This program is distributed in the hope that it will be useful,
but WITHOUT ANY WARRANTY; without even the implied warranty of
MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
GNU General Public License for more details.

GPL v3 (LICENSE)

wanikani-for-android's People

Contributors

alexdragutu avatar aralox avatar edluo1 avatar kufii avatar lasrod avatar liquidfire avatar veyndan avatar xiprox avatar zsparal avatar

Stargazers

 avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar

Watchers

 avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar

wanikani-for-android's Issues

New level lessons mixed with old level

I just reached level 2 although I hadn't even unlocked every vocab on level 1 yet. So now I have ~50 new level 2 lessons mixed with lessons from level 1, and the lesson order seems to be totally random.

I would like to finish level 1 before starting on level 2. Is it possible to delay or selectively do the level 1 lessons first?

Every 10 words (or so) while reviewing an impassable state is reached

First of all, your app is great.

There's a problem that has been preventing me from doing my reviews on mobile.

Here's what happens after I do a handful of reviews. I could debug this myself but I'm busy working on other projects so I'll open it here.

This state is reached.

TextField is unfocusable and > button ineffective. Perhaps caching issue?

image

Settings

Here are my relevant settings in case a user script is causing the issue.

image

image

image

Switching to other task kills app

This just started happening now and havent made any changes to my phones configuration.

Whenever I change to another task or go to the desktop, the app doesnt remain open in background. When pressing the square every other recent app apears save for WK. Even if pressing square while on WK, it doesnt appear as a recent/open app, as if it were running incognito or something.

Obviously, when I open WK again, my study o review session must be restarted and I have lost some progress.

Has this happened to anyone?

Full screen text input in landscape with hardware keyboard

How to reproduce:

  1. Connect a bluetooth keyboard to your phone.
  2. Rotate phone to landscape
  3. Do reviews in the app.

Expected result:
I should be able to do reviews while still seeing the input field. Since I'm using a hardware keyboard there is no virtual keyboard that takes up half the screen and there is no need to show a full screen text input widget.

Actual result:
A full screen text input widget is shown, so I can't see the rest of the web page. Makes hardware keyboard + landscape mode on a phone more or less useless.

[Feature] Auto-advance on correct answer without pressing Enter

Similar to Memrise's system where you automatically progress to the next question if you have typed the correct answer.

Rough idea on how to implement this:

  1. At the start of the review session, obtain a list of all items to be reviewed, perhaps by combining the 'active' and 'review' queues like in the ReviewOrder script.
  2. Obtain a list of correct answers for every item in that review list, be it a collection of meanings or kana readings. Do this by making a list of all the levels spanned by the items in the review list, then loading information for those levels using the WaniKani API. All the items and the information we need will now be in one List<BaseItem>. It might be a good idea to discard unneeded items, then turn the list into a dictionary keyed by item character. Producing this dictionary only needs to be done once per review session.
  3. During the review, after a letter is typed (romanji or kana), check if the full answer exactly matches any of the allowed answers. If so, progress to the next question.

Unable to edit synonyms

When editing / adding a synonym, the keyboard only shows for something like 5 seconds before disappearing again.

Single mode is default now...?

I'm sure it was intentional, but single mode seems to be on by default right now. Is that really a good idea?

Seeing as it's not a part of the default desktop WaniKani experience, it's odd that it would be in this app. What's more, the little 1 symbol doesn't really make it at all clear what it does, introducing a confusing new workflow for people who haven't used it before, with the way to turn it off not being apparent.

[Feature request] reading>meaning

Hey, I really like this app, but ever since starting on wanikani, I have been using a userscript that changes the order of my reviews to reading>meaning, instead of the default meaning>reading. Thus forcing me to remember the reading first and "helping" me think in Japanese (if that makes sense)

I would love to see an option added to change the order in the app also since it really throws me off every time I do my reviews on my phone, I have to actively remember to type the meaning first.

I hope this is at all possible, and if that is too much effort to implement an additional order, maybe it is easier or faster to just replace the order and have a separate apk with only the reading>meaning order?

App gets stuck after correct answer in Reviews

Running the latest Alpha version.

Sometimes, after correctly answering a Reading question and clicking to go on, its answer seems to be dragged into the next question, which becomes un-answerable and un-skipable. Once this happens, it is imposible to go forward (sacrificing the current question) because the > arrow won't do anything, only going back by pressing Home or <- arrow is posible. It has happened about five times since installing the Alpha a couple of days back.

In this case, previous question was "ganmen" and, I believe, this reading was "tombstone" (or whatever it might have been XD). As can be seen, to to and ne were added to the previous "ganmen" as I tried to answer this new question.

screenshot_2017-09-05-23-28-04

App crashes when trying to login

I just downloaded it on iOS 10.2.1 on the iphone, but every time I log in the app crashes. I've tried uninstalling and reinstalling it, but it still happens, so I can't even use the app...

App crashing and not working

Samsung S8.
Installed app, managed to input API key - now app is crashing every time I try to open it. Notifications are shown but if I click app crashing.
Not usable at all.

Simplify Login Experience

Hey İhsan,

I just had an idea for simplifying the initial login process... I thought that the user could log in to WaniKani using the in-app browser instead of another installed one. That way, the user could log in to WK, fetch the API key, and then be able to start immediately using the app without having to go to Lessons or Reviews and need to log in again before gettinng started, because the in-app browser would preserve the login status(right?)

I did something similar for the WaniKani Companion extension for Chrome, and it worked out well. I just inserted a direct link to the API Key header on the WK settings page. It is this:

Reviews always force a portrait layout

When you go into the reviews screen, it always switches the layout to portrait even if you were in landscape mode before.

I understand there were some issues with the keyboard covering up the answer box etc in landscape mode previously (#1). But if your device has a large screen or a physical keyboard these should not be a problem.

For example, on a Pixel C with the physical keyboard attached it makes no sense to rotate to portrait mode when the keyboard is attached, because you can't use the keyboard sideways.

Dev branch issues

I've been trying to work on a thing I think may need changing in the app, but when I run the dev branch it seems like there's a few problems with it that I don't see in the Google Play Store version:

  1. No notifications are shown at all when review time comes up or even after.
  2. Sometimes the vocabulary doesn't update itself after going to the next one, so sometimes for a vocab term, the displayed prompt is for the "vocabulary meaning" but you're actually supposed to input the reading. Other times, the wrong kanji shows up and doesn't update until you press a different button.
  3. The checkmark box marking things recently completed doesn't update properly.
  4. The app crashed in the Vocabulary section when I tapped the filtering button twice in a row sometimes.

Settings enabled:
Use custom fonts
Recent unlock number: 3
Enable notifications
Enable reminder notification
All the default userscripts + Mistake delay

Is there anything I can do to deal with these things?

api key

Hello, how to get your API key

Sudden drop in volume

Im running the beta available in Google Play.

When doing reviews, if i receive any sort of alert (sms, whatsapp, etc), there is a steep drop in the app's volume when it autoreads vocab, it goes down to barely audible and does not recover. Even if I raise the device's overall volume, the app's just barely increases.

"looking for the kun'yomi reading" pop-up obscures "view the correct reading" button

If you enter the wrong reading for a kanji, the "WaniKani is looking for the kun'yomi reading" pop-up will appear, but not disappear. If you then enter the incorrect answer, the "Need help? View the correct reading and mnemonic" pop-up will appear, but the "looking for the kun'yomi" pop-up prevents you from actually clicking on the correct reading button.

screenshot_20161103-080508

Cannot enter katakana by using uppercase

When trying to enter katakana by using the uppercase english alphabet, the uppercase letters are converted to lowercase automatically, and thus only hiragana can be entered.

This is not critical, since all the readings that have katakana have readings with the equivalent hiragana as well, but it would be nice to be able to type katakana properly.

Suggestion for notification setting

This isnt an issue rather a suggestion, when you implement notifications it would be great if there was option to notify user when next current level kanji is available as getting them right as soon as possible is the key to leveling up faster.

Regards,

Garth

No audio autoplay in reviews

It works when doing lessons but when doing reviews, I always have to press the little speaker to get the audio =/. It's not really that big a deal but it would be a nice fix to make it even better :D.

F-Droid

Hi @xiprox

Since the app is licensed under GNU GPL v3, can you consider adding this app to the F-Droid repository? (I don't know if you're using proprietary libraries, but it doesn't works with F-Droid, we sometimes can build the app without them)

I can give you documentation and links if you need it ;)

IME keyboard issue

I like to use Google's Japanese 12 key input because a) I find I make less typos for pronunciation and b) I've been trying to strengthen the connection between the sound and the kana symbol without the romaji bridge I'm between. In the app, when I switch my Gboard keyboard to Japanese, it immediately switches the input to 12 key romaji instead of defaulting to kana like the keyboard should. It doesn't do this on the site. I have the GBoard keyboard 3rd party from the play store, if that makes a difference.

Opening the 'Item Info' panel during review disables WKImprove script (auto-forward)

To reproduce this,

  • Enable 'Wanikani Improve' script in settings
  • Start review, get something wrong
  • Click on the 'item info' panel (eye icon)
  • Continue with reviews. Thereafter, the auto-forward feature of the 'Wanikani improve' script is disabled.

Android 7.0, latest dev branch (and also release branch).

The 'item info' panel is a part of the official Wanikani review page, so the problem seems to lie with the WKImprove javascript somewhere.

Logcat:

07-02 22:46:09.075 22008-22008/tr.xip.wanikani:webview I/chromium: [INFO:CONSOLE(1)] "answerException: wrong answer", source:  (1)
07-02 22:46:09.075 22008-22008/tr.xip.wanikani:webview I/chromium: [INFO:CONSOLE(1)] "Wrong answer", source:  (1)
<I click on the item info panel>
07-02 22:46:24.960 22008-22008/tr.xip.wanikani:webview W/IInputConnectionWrapper: finishComposingText on inactive InputConnection
07-02 22:46:24.989 22008-22008/tr.xip.wanikani:webview D/cr_Ime: [InputMethodManagerWrapper.java:59] isActive: true
07-02 22:46:24.989 22008-22008/tr.xip.wanikani:webview D/cr_Ime: [InputMethodManagerWrapper.java:68] hideSoftInputFromWindow
<From here, console messages from WKImprove script do not show up anymore>

I've identified that answerException (answerException = $.trim($('#answer-exception').text());) in WaniKaniImprove.java is blank after the item info panel is opened.

I compared the body html of a wrong answer when the item info panel had not been opened with the html of a wrong answer after it had been opened, and found that the answer-exception element was missing in the latter case.

I'm working on this issue, but any advice would be appreciated. :)

WaniKani keyboard shortcuts doesn't work during reviews with hardware keyboard

How to reproduce:

  1. Connect a bluetooth keyboard to your phone.
  2. Do reviews in WaniKani.

Expected results:
Pressing enter should submit the answer, Pressing "f" should show details after an answer has been submitted. Pressing space should show more details.

Actual results:
Enter doesn't submit the entered text. Pressing other keys doesn't invoke the expected keyboard shortucts WaniKani supports.

It's like keypresses from the external keyboard isn't forwarded to the WebView.

Pressing Enter on Bluetooth keyboard does not submit review

I'm using the app on a Pixel C with its physical keyboard (which connects as a Bluetooth keyboard). When I type an answer to a review and press Enter on the keyboard, nothing happens. I have to press the submit button on the touchscreen to move on to the next review. This is very inconvenient as you have to take your hands off the keyboard every couple of seconds and hit a tiny button on the touchscreen.

When doing reviews through the WaniKani website on Firefox the Enter button works correctly.

Pixel 2 Android 8.1 Won't Load

It appears that issues are supposed to be posted here instead of the wanikani community forum. After the app accept my API Key the dashboard does nothing but load, same if I attempt to press most pages. However if i click "review" or "lessons" it will go to my current lessons and reviews in the app. I am not getting any errors posted or any other messages so I am unsure if there is a way I can post a log.

Way to tell lvl up?

It would be great if you could tell when a radical/kanji/vocab actually goes up or down a level (apprentice to guru for example) when you are reviewing.

Critical items all appear as locked

All my critical items appear as locked from the main dashboard, and greyed out. Clicking on them says progress is locked, but I definitely seen them in reviews.

App requires login to do reviews but username/password is always incorrect

At about 29 November 2016, the WaniKani developers made some changes and described them as follows:

_**Nothing was done to the API. Any changes to the API are versioned, and thus shouldn't break the scripts...

Some minor changes to the javascript for both lessons and reviews were made. The site's jQuery dependency was just updated to latest (we were four versions behind); there were a few deprecations we had to address and it (our changes or the scripts dependency on our loaded jQuery) may have caused the scripts to break.

You'll need to contact the script authors since we don't officially support the scripts.**_

Since that time, I have been unable to do reviews or lessons with the app. I can see how many reviews / lessons I have because the API is being processed correctly. When I try to do a review, I am prompted to enter email/username + password. Then I press "sign in". I always get a message about "incorrect username / password". I have done this at least ten times. Other people have reported the same difficulty on the WaniKani forum thread for this app.

Perhaps your code needs to be reviewed and/or recompiled to resolve this issue?

I installed this app on Sony Xperia Z2 android 6.0.1.

Many thanks for making this app available.

Dashboard will not refresh

My dashboard on the app won't refresh and has been stuck with the same data for months. The app still works when you click on "Reviews". It does take you to your current reviews, it's just the dashboard as well as the Android notification prompt do not refresh.

Also appears to be constantly refreshing, but never actually doing so.

screenshot_20171125-132221

New to Git Hub, apologize if this isn't the right way to file a bug.

Tablet problems

Hi! The app is really great, but I have a problem depicted on this screenshot:

Screenshot

Sure, I can swipe to see the item displayed, but it's very inconvenient.

(Also, a bit unrelated: ports of some userscripts would be very useful; just like in the old app.)

WK app crashing after API input

Hi!

I've had the same issue as Be-ran (#48) - the answer there was to apply for Alpha-testing, but I can't seem to be able to do that: google says I'm not eligible to apply for alpha testing. Is there something I can do?

[Feature request] Disable audio

Please add an option to disable downloading the audio files. They make up 99% of my data usage for Wanikani.

There is an option on the main site to disable audio for my account, which works, but then it disables audio on PC too, which I don't want.

Lessons quiz input gets stuck at ignored state after first batch

Finishing a batch of lessons and getting to the quiz of the next batch, a user is greeted with an orange input field (ignored state) and there's no way to turn it into normal or to submit an answer right there. Thankfully, they can switch to another app (or open the recent apps menu, really), come back to WaniKani, and the problem will be solved.

Can be reproduced in latest alpha. Other releases not tested.

Mute button mutes whole device

For some reason the mute button mutes my whole device when enabled. I'm not sure if jt was caused by the last update of the app or my OS update.
Device info: OnePlus 3, Oxygen OS 4.0.2, Android 7.0
Have there been any other cases of this happening?
Thanks

Crash when going from vertical to horizontal view.

I tried to find the bug in the code but I'm too new to android development to fully understand how to debug this properly.

Either way... The crash happens 9 of 10 times if you:

  1. Start the app vertically.
  2. Let the application do it's update.
  3. Scroll down the page a little bit.
  4. Rotate to horizontal view.
  5. Crashes.

I can reproduce the crash in Android Studio as well as on the phone.

Add contact method

Hi, I just wanted to send you a small message thanking you for the work you've done on the app, to accompany the in-app donation I also sent you 😄

But I couldn't find contact info, and since the app also has no contact button, I'll just write it here.

Hope you'll get yourself something nice to eat!

またね~~

Last entered lesson input remains for the next lesson

There appears to be a bug with the latest version of WK.

Issue
On second and subsequent lesson blocks, the last answer from the previous lesson is present in the input field.

Steps To Reproduce
Create a scenario where the app will offer to continue to the next set of lessons. Complete the first set, and then go directly to the second set. The text from the last lesson will be present in the input field.

I'm using v1.2.6 on a OnePlus 3T running OxygenOS 4.5.1 and Android 7.1.1

Display on'yomi in katakana

I'd like to request this feature because I'm used to learning them in katakana - my wife also would like this because it really helps her to train her katakana.

Horrible battery drain

With this app installed and idle I'm consistently losing around 3-4 hours of screen on time

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.