Comments (12)
Ok. I take it that it's solved for you as well now? Guess this issue can be closed.
from wanikani-for-android.
from wanikani-for-android.
I'm aware. It's been happening to me as well and it's annoying as hell. Pretty sure it was introduced with #49. Haven't had the time to look into it yet though.
from wanikani-for-android.
@Aralox If you have an idea or could tackle this anytime soon, that'd be great.
from wanikani-for-android.
I'll have a look tomorrow after work (2245 at the moment)
from wanikani-for-android.
Submitted a PR (#52). It's a pretty simple bug which I should have found before submitting my last pull request - my bad.
I had to create a new WaniKani account to test reviewing radicals, as I have too many vocab reviews on my main account. I've not tested the exact scenario you described @squasheds, as I don't have any reading reviews available yet. I'm fairly confident it only happens for radicals, but please try out the fix and let me know anyway. I'll verify it once I unlock some kanji on my new account :).
@xiprox, how would you like pull requests to be done? I just made my change on the master branch and committed, but do you prefer if I made a new branch for any changes?
Also, could you please mention in the readme that to compile the project, we have to create a google-services.json
file from https://developers.google.com/mobile/add and add it to the WaniKani folder inside the repo (this also seems to be why the CI is crashing at the moment).
from wanikani-for-android.
I'll be taking a look at the #52 shortly.
And yes, on-topic names for branches would probably be nice.
from wanikani-for-android.
Has the fix been implemented in the available beta at playstore? I downloaded it three days ago and there has been no new update. I just had the bug happen twice again today when going from a reading question to a radical one. Yesterday it also happened when going from a meaning question though I dont remember to which kind of question it crossed.
from wanikani-for-android.
@squasheds The change is now up on the alpha track on the Play Store. I haven't been able to test it myself, so can't say if it works for sure.
from wanikani-for-android.
App updated 3 hours ago, problem persist on my phone. Any debug log or other info I can contribute?
from wanikani-for-android.
I just did around 40 reviews in different batches and had no occurrences of this issue. In contrast, reverting #52 brings back the error even with only a few reviews.
@madmalkav Are you sure you are on the latest alpha, again? I just promoted alpha to beta though, so you should get it there in a bit anyway. EDIT: It's now live in the beta.
from wanikani-for-android.
from wanikani-for-android.
Related Issues (20)
- Display on'yomi in katakana HOT 3
- Notification doesn't disappear after taking action
- App crashing and not working HOT 3
- Pixel 2 Android 8.1 Won't Load HOT 5
- WK app crashing after API input HOT 4
- F-Droid HOT 1
- Last entered lesson input remains for the next lesson HOT 2
- Dashboard will not refresh HOT 4
- Add contact method HOT 1
- IME keyboard issue HOT 2
- Kanji window isn't updated
- Offline Compatibility HOT 2
- Vacation mode uses huge amounts of data
- Kana modifier button in samsung kana keyboard disabled HOT 1
- last version HOT 2
- Notifications not working HOT 2
- Weird interaction with Messagease
- [Feature request] darkmode
- Feature Request: Show Similar Kanji Userscript Option
- Removed from App Store? HOT 1
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from wanikani-for-android.