Code Monkey home page Code Monkey logo

Comments (3)

delucis avatar delucis commented on May 12, 2024 2

Thanks for the report @jamescmartinez! I can confirm we’re not currently respecting build.format or trailingSlash when building links. Should be do-able though and would welcome a PR!

Our general method for making user configuration from astro.config available to components etc. is via virtual modules and you can see that in place here:

starlight/packages/starlight/index.ts

Lines 85 to 94 in 7f4e948

/** Expose the Starlight user config object via a virtual module. */
function vitePluginStarlightUserConfig(
opts: StarlightConfig,
{ root }: AstroConfig
): NonNullable<ViteUserConfig['plugins']>[number] {
const modules = {
'virtual:starlight/user-config': `export default ${JSON.stringify(opts)}`,
'virtual:starlight/project-context': `export default ${JSON.stringify({
root,
})}`,

We currently expose the project root via the virtual:starlight/project-context virtual module, but could add trailingSlash and build.format to that module so that Starlight code can do something like:

import project from 'virtual:starlight/project-context';

const link = project.build.format === 'file' ? '/foo.html' : '/foo/';

from starlight.

jamescmartinez avatar jamescmartinez commented on May 12, 2024 2

I didn't have time to wrap this up tonight, but here's a start: #207

from starlight.

kevinzunigacuellar avatar kevinzunigacuellar commented on May 12, 2024 1

I would like to take a swing at this one 🚀

from starlight.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.