Code Monkey home page Code Monkey logo

Comments (4)

pavanpodila avatar pavanpodila commented on June 5, 2024 1

Hi @delucis,
After a bit more debugging I found that the problem was with the firebase.json configuration. It was using the source property instead of the public property, which was forcing it to build it in development mode. After switching to public: "dist", it started working correctly. Looks like a bug in the firebase-tools cli.

from starlight.

pavanpodila avatar pavanpodila commented on June 5, 2024

Looks like the import.meta.env.DEV is true even in astro build. Not sure if it is getting passed correctly on astro build. If search indexing is happening, I think it is getting set, just not being passed to the components ?

Search component check: https://github.com/withastro/starlight/blob/main/packages/starlight/components/Search.astro#L41

from starlight.

delucis avatar delucis commented on June 5, 2024

Thanks for the issue @pavanpodila!

Couple of questions:

  1. If you run the build locally and preview (npm run build && npm run preview), does search work as expected?
  2. Could you try logging import.meta.env.DEV somewhere in your code to see the value when building on Firebase? It shouldn’t be true when running astro build, but maybe there’s something special about the Firebase environment?

from starlight.

delucis avatar delucis commented on June 5, 2024

Thanks for the update and happy to hear you’ve got it working 🙌

from starlight.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.