Language Select incorrectly appends locale when switching index pages about starlight HOT 5 CLOSED

Happy to tackle this if we have no other takers. I will leave it open if anyone is interested.

from starlight.

I think we can definitely take that as our working hypothesis.

I'm still feeling like our use of build.format as also determining link format may not be what everyone wants, but I think it's ok for us to get this consistent at this point and think about that later when we hear from folks what they need.

from starlight.

Thanks for finding this @kevinzunigacuellar! I can confirm I see this in the build output of your reproduction. The language picker produces the following HTML:

<select value="/en/en.html">
	<option value="/en/en.html" selected="true">English</option>
	<option value="/es/en.html">Spanish</option>
</select>

value is set here:

So this would be a bug in the localizedPathname() function.

Are you up for Even More Fun With URLs™️?

from starlight.

Thanks @kevinzunigacuellar! I tried writing a few tests on the train earlier and the one thing I realised I'm not sure about with sites using build.output: 'file' is what they do for the homepage, like is it example.com/index.html? Or would they expect to special case that as example.com/? I'm honestly not sure what expectations are.

from starlight.

I think they would expect example.com/index.html. example.com/ would probably redirect to example.com/index.html

from starlight.