Code Monkey home page Code Monkey logo

Comments (2)

delucis avatar delucis commented on May 26, 2024

Thanks for the issue @boneskull and for your patience waiting for a reply!

This is a super tricky one (tables in general are to be honest 😅) and I’m honestly not 100% sure what the right answer is.

While your example template is definitely not pretty, consider another example where the second column value is a long code string. With the current styles, these wrap like this:

image

If we disable the overlow-wrap: anywhere for <code> inside tables, initially things seems quite OK:

image

But if we switch to a narrower viewport, I’m not so sure this is still better:

With overflow-wrap Without overflow-wrap
image image

Admittedly tables are close to impossible to display well on smaller screens, which is why in the Astro docs we aim to avoid them altogether and in Starlight’s docs we only have one, extremely narrow, two-column table.

So, I’m not sure what the right solution here is. Curious to hear further thoughts and suggestions though.

(EDIT: I accidentally closed the issue somehow while commenting, sorry, not my intention.)

from starlight.

boneskull avatar boneskull commented on May 26, 2024

What if we adjust the setting based on the viewport size?

If we expect users of Starlight to mainly produce technical documentation, developers read it. Developers are going to favor larger displays when developing (idk if you've ever tried to code anything on your phone, but even typing a few lines in a GH issue is painful). To that end, it seems like the desktop display should be favored over mobile when the two come to loggerheads. What do you think?

(I suppose this mainly concerns how code blocks get displayed, because that's really the thing that causes the conflict)

from starlight.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.