Comments (2)
Thanks for the issue @boneskull and for your patience waiting for a reply!
This is a super tricky one (tables in general are to be honest 😅) and I’m honestly not 100% sure what the right answer is.
While your example template is definitely not pretty, consider another example where the second column value is a long code string. With the current styles, these wrap like this:
If we disable the overlow-wrap: anywhere
for <code>
inside tables, initially things seems quite OK:
But if we switch to a narrower viewport, I’m not so sure this is still better:
With overflow-wrap |
Without overflow-wrap |
---|---|
Admittedly tables are close to impossible to display well on smaller screens, which is why in the Astro docs we aim to avoid them altogether and in Starlight’s docs we only have one, extremely narrow, two-column table.
So, I’m not sure what the right solution here is. Curious to hear further thoughts and suggestions though.
(EDIT: I accidentally closed the issue somehow while commenting, sorry, not my intention.)
from starlight.
What if we adjust the setting based on the viewport size?
If we expect users of Starlight to mainly produce technical documentation, developers read it. Developers are going to favor larger displays when developing (idk if you've ever tried to code anything on your phone, but even typing a few lines in a GH issue is painful). To that end, it seems like the desktop display should be favored over mobile when the two come to loggerheads. What do you think?
(I suppose this mainly concerns how code blocks get displayed, because that's really the thing that causes the conflict)
from starlight.
Related Issues (20)
- Left sidebar scroll bar problem HOT 2
- config options are not followed in pagefind search
- CSS not displaying on pages other than homepage HOT 4
- Hot Updates Reporting Errors Causing Project Crashes HOT 1
- Throws on reading `import.meta.env.BASE_URL` in Deno environment HOT 10
- Pagefind not working with PNPM and Firebase Hosting HOT 4
- do something about empty autogenerated sidebar groups HOT 1
- Astro devToolBar audit create a warning on code block HOT 4
- font not rendered correctly on firefox
- Language Select incorrectly appends locale when switching index pages HOT 5
- Mobile header cannot accumulate long documentation name and it covers search button HOT 1
- Table of Contents Glitch HOT 3
- Both dark and light Starlight appears when JS disabled HOT 1
- Letters get auto-generated in front of Frontmatter when have closing HTML tag in Markdown. HOT 4
- Embed Microsoft Video Not Working on Safari HOT 3
- Search not working in Cloudflare workers HOT 4
- Failing to import night-owl-dark.jsonc?raw HOT 10
- Select options are not centrally aligned HOT 2
- UI text not translated when creating a multilingual site with only one locale HOT 3
- TypeScript errors when using TS with Project References HOT 1
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from starlight.