wirelessalien / bhagavadgitaapp Goto Github PK
View Code? Open in Web Editor NEWA Simple Open-source Android App for Bhagavad Gita
License: GNU General Public License v3.0
A Simple Open-source Android App for Bhagavad Gita
License: GNU General Public License v3.0
The app/src/main/res/drawable/launcher_icon_light.xml is not in your apk. Removing it fix the build. Is it missed from you build?
Description of the bug
When I try to change the theme of the app from Light
to Dark
and then again Light
, the About Gita
comes forth behind the alert dialog and the main activity disappears. Even when you click back, the app exists.
To Reproduce
Steps to reproduce the behavior:
About Gita
screen from the three-dot menu in the app barChange Theme
options menu item in the app barAbout Gita
page to pop)Expected behavior
About Gita
screen must not come forth and the app should remain in the Main Activity (i.e. Home screen)
Description
When I open the app for the first time after installing it, it opens with the Light Theme as the default theme selected. Although, it is the Light Theme
that is displayed in the selection, the actual app theme is the one that is selected in the system-wide android theme mode in the android settings, which shouldn't be the case. Let's say I my device theme is "Dark Theme
" (for android 10+), and I am opening the app for the first time, the app opens in dark mode because of this issue, now I change the app theme to Dark Theme
, nothing happens as it is already in the dark mode, and I again change it to Light Theme
, this time the app changes to light theme. Now, I close the app and remove it from the background (recents menu) as well, and I reopen the app, the expected behavior is the app must open in Light Theme
, but instead it follows the android's system-wide theme mode.
To Reproduce
Steps to reproduce the behavior:
Light Theme
as selected)Dark Theme
and back to Light Theme
Light Theme
, although the app is still displaying in dark modeExpected behavior
The app should always be displayed in the theme that is shown as selected in the theme's alert dialog.
String resources are duplicated into night and non-night strings.xml files
I may be wrong but I don't know why there was a need to split strings.xml into two different files i.e. in the night and non-night string resource folders of android.
Expected behavior
I have my own version of Bhagavad Gita app available on Play Store, and I certainly have not duplicated string resources based on the night mode flags; yet, I am able to retrieve the string resources irrespective of whether the app is running in light mode or dark mode. In your case, since you have lesser string resources, it doesn't impact much on the app size. But yes, you can use just one strings.xml in the res/values folder to reduce a few bytes of the source code.
Additional context
In my case, I am using my own translations, not retrieving them from any online repo/website. Also, since my app supports 10 languages, if I were to make two (night and non-night) versions of each strings.xml, it would have significantly affected my app size. It's after all your app, you are the one to decide.
Feature Description
A quick search feature for searching Bhagavad Gita content faster would be highly appreciated. If not search, then some kind of mechanism to navigate directly to the verse of a given chapter without having to navigate from first the Chapter and then to the Verse. It would be better to display a list of the matched verses and upon clicking it, it should display the complete details of that verse.
Alternatives to the feature
Dropdowns for the Chapter and the Verse numbers and a button upon clicking which the user will be navigated to that particular verse of that chapter.
this above line uses verse_number
to open translation.
But the json has verse number resets for each chapter.
BhagavadGitaApp/app/src/main/assets/verse.json
Lines 566 to 577 in cc48a21
Thus the translation on verse 48 open verse 1 and not the correct verse.
so the code should ideally use verse_order
instead of veser_number
.
ps: thanks for the app.
Thank you for this amazing app, it helps in many ways. Can you please consider using amoled dark mode and Google material you theme? Thanks again 👍
Is your feature request related to a problem? Please describe.
Random verses are displayed on top in the main window of the app. This is great but it is currently not possible to click the random verse and read it in detail.
Describe the solution you'd like
The random verses displayed on the main page should be made clickable. When clicked, the app should display the full page corresponding to that verse.
Describe alternatives you've considered
None
Add haptic feedback when swiping from one verse to next.
Hi Abhilash,
First, I want to thank you for creating this app, I am a Hindu, so it is much appreciated. I waned to ask you if you can add two features to the app. Firstly, I want that a person can increase the font size as I wanted my mom to have the app, but she can't see that small of a text. And another feature I want is the ability to copy text from anywhere in the app, so that I can share it to anyone anywhere.
Warm regards,
Akshit Guleria
A declarative, efficient, and flexible JavaScript library for building user interfaces.
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
An Open Source Machine Learning Framework for Everyone
The Web framework for perfectionists with deadlines.
A PHP framework for web artisans
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
Some thing interesting about web. New door for the world.
A server is a program made to process requests and deliver data to clients.
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
Some thing interesting about visualization, use data art
Some thing interesting about game, make everyone happy.
We are working to build community through open source technology. NB: members must have two-factor auth.
Open source projects and samples from Microsoft.
Google ❤️ Open Source for everyone.
Alibaba Open Source for everyone
Data-Driven Documents codes.
China tencent open source team.