Theme states are not preserved about bhagavadgitaapp HOT 4 CLOSED

I am actually aware of the problems with theme change. To apply only light & dark theme easy, but the way the black theme was applied was not a great way. I will have to change the theme change method.

from bhagavadgitaapp.

I have fixed light, dark and black theme modes on your app. I removed the change theme function to be invoked from radio button clicks to the positive button click of the dialog box (dialog fragment). But there are minute errors that I am able to see - the option menu items are not recreated and retain their previous mode's color, meaning let's say you have switched from light to black mode, when the app was in light mode, the menu items color was black, not it should have changed to white, right? But that doesn't happen. Weird behaviour... will have to dig deep into it to find out why that happens.

I'll create a PR once I am convinced with my solution :) Hope that will be accepted by you.

from bhagavadgitaapp.

Your shared preferences tags are cluttered... Have you tried making a single class holding all the sharedpref tags in one place? That way, you'll get the exact string you need to get their values and it'll be more organised. I am trying to correct the way black, light and dark themes were implemented. Let me see what works well.

from bhagavadgitaapp.

Your shared preferences tags are cluttered... Have you tried making a single class holding all the sharedpref tags in one place?

I have not tried only thought about it later (like- If I can manage time maybe I will do it 🙂)

That way, you'll get the exact string you need to get their values and it'll be more organised.

Yeah, that's true.

I am trying to correct the way black, light and dark themes were implemented. Let me see what works well.

👍

from bhagavadgitaapp.