prj-rev-bwfs-dasmoto's Issues
Alt Attribute
It is best practice to include the alt attribute for images for several reasons:
- It optimizes your site for search engine results
- Increases the accessibility of your page.
- The attribute is used as a backup in the chance that the image cannot be rendered.
Considering you can include the attribute in the following way:
<img src="https://s3.amazonaws.com/codecademy-content/courses/freelance-1/unit-2/hacksaw.jpeg" alt="Hacksaw brushes stacked on a table">
Reducing Duplicate CSS
When writing CSS, it is best not to have duplicate code as it makes it harder to maintain a project. Here you apply the following CSS to three different sections
font-family: Helvetica;
font-size: 32px;
font-weight: bold;
color: white;
Instead of applying the styles to each section separately it is better to do the following:
/* Apply the style all the elements share */
div h2 {
font-family: Helvetica;
font-size: 32px;
font-weight: bold;
color: white;
}
/* Apply the unique background color they all have */
#brush {
background-color: mediumspringgreen;
}
#frame {
background-color: lightcoral;
}
#paint {
background-color: skyblue;
}
prj-rev-bwfs-dasmoto/Dasmoto' Arts &Crafts/dasmoto.css
Lines 31 to 37 in 494adaf
Character entity reference
The ampersand symbol is a reserved character in HTML since it is used to add characters via an entity reference.
You'll notice that GitHub recognizes this as it is currently highlighting the symbol in red.
Considering this the correct way to an ampersand is by replacing &
with &
Syntax error
You have a small error here considering you have center followed by horizontal for the text-align property.
Summary
Grade: Meets Expectation
Summary:
Sarita, congrats on completing the Dasmoto project! Overall you did an excellent job using classes and ids appropriately in your HTML file. You also did a nice job meeting the visual specifications of the project.
A couple of things to keep in mind are syntax errors as I saw a couple in your project (#5 & #4). Browsers are very lenient when it comes to syntax and will let you get away with having errors here and there but at moments they will cause unwanted bugs, so it is best to avoid them at all cost.
As well consider reading over this style guide to improve the readability of your CSS file. I saw some inconsistencies here and there which you should try and avoid such as having a space after an opening brace .selector {
vs .selector{
.
Formatting
Consider improving the formatting of your file. Take for example this HTML solution of the project and notice how elements are nested to enhance readability.
This article also talks more about proper formatting.
prj-rev-bwfs-dasmoto/Dasmoto' Arts &Crafts/Dasmoto.html
Lines 14 to 21 in 494adaf
Extra semicolon
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
๐ Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. ๐๐๐
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google โค๏ธ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.