Code Monkey home page Code Monkey logo

prj-rev-bwfs-dasmoto's People

Contributors

webgodess avatar

Watchers

 avatar

prj-rev-bwfs-dasmoto's Issues

Reducing Duplicate CSS

When writing CSS, it is best not to have duplicate code as it makes it harder to maintain a project. Here you apply the following CSS to three different sections

font-family: Helvetica;
font-size: 32px;
font-weight: bold;
color: white;

Instead of applying the styles to each section separately it is better to do the following:

/* Apply the style all the elements share */
div h2 {
  font-family: Helvetica;
  font-size: 32px;
  font-weight: bold;
  color: white;
}
/* Apply the unique background color they all have */
#brush {
  background-color: mediumspringgreen;
}
#frame {
  background-color: lightcoral;
}
#paint {
  background-color: skyblue;
}

#paint{
font-family: Helvetica;
font-size: 32px;
font-weight: bold;
color: white;
background-color: skyblue;
}

Summary

Grade: Meets Expectation

Summary:
Sarita, congrats on completing the Dasmoto project! Overall you did an excellent job using classes and ids appropriately in your HTML file. You also did a nice job meeting the visual specifications of the project.

A couple of things to keep in mind are syntax errors as I saw a couple in your project (#5 & #4). Browsers are very lenient when it comes to syntax and will let you get away with having errors here and there but at moments they will cause unwanted bugs, so it is best to avoid them at all cost.

As well consider reading over this style guide to improve the readability of your CSS file. I saw some inconsistencies here and there which you should try and avoid such as having a space after an opening brace .selector { vs .selector{.

Formatting

Consider improving the formatting of your file. Take for example this HTML solution of the project and notice how elements are nested to enhance readability.

This article also talks more about proper formatting.

<div class="part 2">
<h2 id="brush">Brushes</h2>
<img src="https://s3.amazonaws.com/codecademy-content/courses/freelance-1/unit-2/hacksaw.jpeg">
<h3>Hacksaw Brushes</h3>
<p>Made of the highest quality oak, Hacksaw brushes are known for their weight and ability to hold paint in large amounts. Available in different sizes.<span> Starting at $3.00 / brush.</span></p>
</div>

Alt Attribute

It is best practice to include the alt attribute for images for several reasons:

  1. It optimizes your site for search engine results
  2. Increases the accessibility of your page.
  3. The attribute is used as a backup in the chance that the image cannot be rendered.

Considering you can include the attribute in the following way:

<img src="https://s3.amazonaws.com/codecademy-content/courses/freelance-1/unit-2/hacksaw.jpeg" alt="Hacksaw brushes stacked on a table">

<img src="https://s3.amazonaws.com/codecademy-content/courses/freelance-1/unit-2/hacksaw.jpeg">

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    ๐Ÿ–– Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. ๐Ÿ“Š๐Ÿ“ˆ๐ŸŽ‰

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google โค๏ธ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.