Comments (3)
I know fs
is an internal module. The reason I usually do an npm install
even for these cases is more for documentation purposes, to document what modules the library depends on, whether it is internal or not. It does not do any harm: what npm
does at installation is just to put a placeholder subdirectory in the node_modules
directory with a simple README and a package.json
; no code is actually installed. I.e., the extra costs is essentially none.
Do you see any major reason why this should not be part of package.json
?
from scribejs.
Well, there are packages like path
, http
, https
and so on which are also inteenal modules but also available on npmjs but contain a completely different code.
Not sure what you want to document but modules like fs
, path
, ... are not needed in package.json.
So it depends on the package what you get. Also the security holding packages often throw a warning during install.
I do not recommend this as this might confuse people who then think that they have to install fs
and other internal modules which might run unwanted code as part of install
or postinstall
.
from scribejs.
Removed fs
from scribejs.
Related Issues (20)
- Hide config from version control HOT 4
- Do we need package 'node-fetch'? HOT 2
- Refactor "convert.io" using regex'es instead? HOT 2
- Do we need "CGI/protocol.js"? HOT 2
- CGI: add option to commit to w3.org space instead of GH repo? HOT 5
- Review input sanitisation HOT 4
- Prevent form against inadequate use HOT 7
- Use npm package 'octocat' instead of interacting directly with the GH API? HOT 2
- Remove the latest ES dependencies from preset.js HOT 1
- Publish scribejs in npm HOT 6
- Do we need field “files” in “package.json”? HOT 2
- Whitespace and coding style? HOT 5
- Add JSON-LD to Jekyll preamble HOT 8
- Markdown id format HOT 1
- GitHub Pages Hosting of new BrowserView HOT 6
- Integrate BrowserView editor with GitHub's Personal Token & API HOT 4
- Validate nickname files in BrowserView HOT 1
- Browserify the tool? HOT 3
- Security alert on marked version HOT 2
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from scribejs.