Code Monkey home page Code Monkey logo

Comments (4)

iherman avatar iherman commented on June 21, 2024

I am not sure what the question is...

The OAUTH Token of GH actually cannot be committed to GH. If you do, GH realizes that and will immediately invalidate the key (it happened to me once). That is one of the reasons why I had to have a config file (~/.scribejs.json or CGI-Executable/.scribe.json) that is never on the Web and can carry the Key.

from scribejs.

iherman avatar iherman commented on June 21, 2024

Oh I am sorry, I get it. But the config file in the test directory does NOT include the GH Token. And it cannot, see #10 (comment). On the other hand, it is useful if others want to test it.

from scribejs.

tripu avatar tripu commented on June 21, 2024

@iherman:

“But the config file in the test directory does NOT include the GH Token.”

It might, at some point.
Or other sensitive info, like local paths or hostnames, username/password for our CVS server, a developer key for the W3C API…

It's good practice to exclude configuration and all particulars from version control, imho. They vary from user to user. And apart from the security concerns, changes in config files add noise to the Git history.

“And it cannot, see #10 (comment).”

It's kind of funny GitHub is catching its own tokens inside attempted commits and aborting them… I guess it's a nice feature, but we should not rely on that.

from scribejs.

iherman avatar iherman commented on June 21, 2024

Ok. I have removed the example config files.

from scribejs.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.