Graceful shutdown about next.js HOT 8 CLOSED

I would argue graceful shutdown is still a relevant feature here, especially for rolling deployments where you don't want to kill in-flight requests.

from next.js.

This is included in the latest codebase:
https://github.com/zeit/next.js/blob/master/bin/next#L47

from next.js.

The code you referenced does not appear to be a graceful shutdown, it's just reacting to the termination of the subprocess?

from next.js.

@ChiperSoft I don't like graceful shutdown at all since server don't shutdown gracefully specially in this cloud era.

But anyway, Next.js should not have databases and stateful things (That's what we recommend).
So, it's totally okay to kill it right away.

About integration testing, you don't need that too. Check our testing suite and how we do it. You don't need graceful shutdown.

from next.js.

@arunoda you should still be waiting for requests to complete before killing the process. a deploy will hang up on anything in flight.

from next.js.

@ChiperSoft better option is to do that with a proxy. (with re-trying)
Most of the proxies does support that. And most of the cloud hosting servers.

Servers could fail at sudden.

from next.js.

I think it's nice to have graceful shutdown for programatic API, even though it's not must. Maybe there is no downside to implement ?

from next.js.

Are there any plans on opening this issue up again? I have the same problem like @ChiperSoft was having: integration tests. I'm not sure how to shutdown the server.

from next.js.