Code Monkey home page Code Monkey logo

Comments (1)

gabrielf avatar gabrielf commented on July 20, 2024

Below is a git path that can be applied to the next.js repo to add a e2e test that fails due to the background-image, created by setting placeholder="blur" for a statically imported image, does not take the trailingSlash: true setting into account.

An image called test.jpg also need to be added to the e2e test using:

mkdir test/e2e/app-dir/trailingslash/public/
cp test/unit/image-optimizer/images/test.jpg test/e2e/app-dir/trailingslash/public/test.jpg
diff --git a/test/e2e/app-dir/trailingslash/app/page.js b/test/e2e/app-dir/trailingslash/app/page.js
index c00ce2fb17..ac956f2d88 100644
--- a/test/e2e/app-dir/trailingslash/app/page.js
+++ b/test/e2e/app-dir/trailingslash/app/page.js
@@ -1,4 +1,8 @@
 import Link from 'next/link'
+import Image from 'next/image'
+
+import testImage from '../public/test.jpg'
+
 export default function HomePage() {
   return (
     <>
@@ -6,6 +10,7 @@ export default function HomePage() {
         <Link href="/a/" id="to-a-trailing-slash">
           To a with trailing slash
         </Link>
+        <Image id="image-with-blur-placeholder" src={testImage} placeholder="blur" />
       </p>
     </>
   )
diff --git a/test/e2e/app-dir/trailingslash/trailingslash.test.ts b/test/e2e/app-dir/trailingslash/trailingslash.test.ts
index b1731aa254..98aba1774b 100644
--- a/test/e2e/app-dir/trailingslash/trailingslash.test.ts
+++ b/test/e2e/app-dir/trailingslash/trailingslash.test.ts
@@ -40,6 +40,12 @@ createNextDescribe(
       expect(await browser.waitForElementByCss('#a-page').text()).toBe('A page')
     })
 
+    it('should render blurred image placeholder with trailing slash', async () => {
+      const $ = await next.render$('/')
+
+      expect($('#image-with-blur-placeholder').attr('style')).toInclude('background-image:url("/_next/image/')
+    })
+
     it('should redirect route when clicking link', async () => {
       const browser = await next.browser('/')
       await browser

from next.js.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.