Code Monkey home page Code Monkey logo

Comments (6)

jenewland1999 avatar jenewland1999 commented on May 10, 2024 1

While aria-disabled does indeed not prevent you from clicking the button itself, it's important to understand why aria-disabled is used to begin with. There's a great article on CSS Tricks about it that's worth a read https://css-tricks.com/making-disabled-buttons-more-inclusive/.

@jenewland1999 Thank you for the additional information.

In my opinion, disabled seems more appropriate than aria-disabled for common examples.

The aria-*** attributes will inform people using assistive technologies, such as screen readers, that such elements are not meant to be editable or otherwise operable.

MDN article explains

Unlike HTML's disabled Boolean attribute, which will communicate a form control as semantically being disabled, change its styling to reflect its state and suppress all functionality along with disallowing the element's value from participating in form submission, the aria-disabled="true" only semantically exposes these elements as being disabled. Web developers must manually ensure such elements have their functionality suppressed when exposed to the disabled state.

I don't disagree that the disabled attribute is more common/familiar and likely easier for the examples because it gives intended behaviour. That said the follow up comments on PR #63852 suggest the intention might be purposefully to promote more accessible examples/docs.

That said it is a bit of a grey area.

from next.js.

byseop avatar byseop commented on May 10, 2024 1

While aria-disabled does indeed not prevent you from clicking the button itself, it's important to understand why aria-disabled is used to begin with. There's a great article on CSS Tricks about it that's worth a read https://css-tricks.com/making-disabled-buttons-more-inclusive/.

@jenewland1999 Thank you for the additional information.

In my opinion, disabled seems more appropriate than aria-disabled for common examples.

The aria-*** attributes will inform people using assistive technologies, such as screen readers, that such elements are not meant to be editable or otherwise operable.

MDN article explains

Unlike HTML's disabled Boolean attribute, which will communicate a form control as semantically being disabled, change its styling to reflect its state and suppress all functionality along with disallowing the element's value from participating in form submission, the aria-disabled="true" only semantically exposes these elements as being disabled. Web developers must manually ensure such elements have their functionality suppressed when exposed to the disabled state.

I don't disagree that the disabled attribute is more common/familiar and likely easier for the examples because it gives intended behaviour. That said the follow up comments on PR #63852 suggest the intention might be purposefully to promote more accessible examples/docs.

That said it is a bit of a grey area.

The suggestion in that pr also looks good. I will change and update soon

from next.js.

byseop avatar byseop commented on May 10, 2024

I fixed it and PR. #63888

from next.js.

jenewland1999 avatar jenewland1999 commented on May 10, 2024

While aria-disabled does indeed not prevent you from clicking the button itself, it's important to understand why aria-disabled is used to begin with. There's a great article on CSS Tricks about it that's worth a read https://css-tricks.com/making-disabled-buttons-more-inclusive/.

from next.js.

byseop avatar byseop commented on May 10, 2024

While aria-disabled does indeed not prevent you from clicking the button itself, it's important to understand why aria-disabled is used to begin with. There's a great article on CSS Tricks about it that's worth a read https://css-tricks.com/making-disabled-buttons-more-inclusive/.

@jenewland1999 Thank you for the additional information.

In my opinion, disabled seems more appropriate than aria-disabled for common examples.

The aria-*** attributes will inform people using assistive technologies, such as screen readers, that such elements are not meant to be editable or otherwise operable.

MDN article explains

Unlike HTML's disabled Boolean attribute, which will communicate a form control as semantically being disabled, change its styling to reflect its state and suppress all functionality along with disallowing the element's value from participating in form submission, the aria-disabled="true" only semantically exposes these elements as being disabled. Web developers must manually ensure such elements have their functionality suppressed when exposed to the disabled state.

from next.js.

github-actions avatar github-actions commented on May 10, 2024

This closed issue has been automatically locked because it had no new activity for 2 weeks. If you are running into a similar issue, please create a new issue with the steps to reproduce. Thank you.

from next.js.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.