vangware / window-open-promise Goto Github PK

When opening promised window on Chrome I got this error

A boolean is being passed as a fourth parameter to window.open. This is not used and may cause an exception in a future release.

A few days ago, with the release of 2.5.1, something broke. It was working perfectly fine with 2.5.0. The version change got declared as a patch. Something that small should not break large even when you refactored micro entirely. Looking at the dependencies involved in your project and the error message gets thrown, something has changed in micro. Has window-open-promise imported from micro before 2.5.1 also consuming the ESM module?

The exception I get is the following. Looking at the implementation of micro, the new typescript operator ?? gets used, but why gets this not converted into unreadable javascript, does it relate with the typescript lib ES2018 used in typescript compilation?

Maybe you can have a look,
Thx!

./node_modules/@vangware/micro/esm/arrayGroup.js 23:56
Module parse failed: Unexpected token (23:56)
You may need an appropriate loader to handle this file type, currently no loaders are configured to process this file. See https://webpack.js.org/concepts#loaders
|     return {
|         ...groups,
>         [groupName]: arrayPush(item)(groups[groupName] ?? [])
|     };
| })({});

Using this library for a long time, ignoring the following error whenever I open the file importing the library.

Unable to resolve the path to module '@vangware/window-open-promise.' eslint[import/no-unresolved] ...

Is it intentional not specifying the module prop to the file which holds all exports? Installing the library, only "type": "module" is set, but the corresponding module declaration is missing. Adding "module": "./dist/index.js" after installing the library fixes the problem.

Thx!