Stopped working since 2.5.1 about window-open-promise HOT 4 CLOSED

The changes in micro shouldn't affect @vangware/window-open-promise at all, that's why the version was flagged as patch (it didn't changed the API, nor added anything new, it's just a dependency upgrade).

Micro is compiled with esm and cjs targets. ESM is only modern JavaScript, and CJS does down-compilation of stuff like nullish coalescence (as you can see in the file that's throwing an error for you, in it's cjs version here).

@vangware/window-open-promise is also compiled in esm and cjs, and both import from @vangware/micro, so the bundler/resolver needs to take care of bundling/resolving the correct path.

Initially I suggest to take a look at your webpack configuration to make sure it imports from cjs instead of esm. If that doesn't work, you should add support for nullish coalescence and optional chaining in your webpack build process (either updating TypeScript to latest if you use TypeScript, or installing the corresponding Babel plugins). Finally check your Node version (14 and above support this syntax natively).

Sorry, but I can't do anything else on my end.

Thanks for reporting!

from window-open-promise.

Thx for the explanation and hints on how to fix it on my side. I will check my setup later and provide feedback; maybe it is just my node version using node 12 LTS. Also, I have to check if this behavior is just happening in dev mode and maybe not on production.

from window-open-promise.

I'm closing this because it seems to be a problem with Webpack. From what I can gather there are some temporary solutions adding rules, or switching entirely to Rollup.

Related bug in Webpack so you can track it: webpack/webpack#7973

from window-open-promise.

I just confirm that the latest version 2.6.0 is working again, many thx!

from window-open-promise.